pkg/analyzer/lib/src/task/strong/rules.dart - Issue 1497803003: Check for void in rules subtyping (fixes #25069)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/task/strong/rules.dart

Issue 1497803003: Check for void in rules subtyping (fixes #25069) (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/task/strong/rules.dart

diff --git a/pkg/analyzer/lib/src/task/strong/rules.dart b/pkg/analyzer/lib/src/task/strong/rules.dart

index ed92a7ecc5a7289ca30b978b3e94fcd1c66eef1e..909a6fb0548cc1bc719deef84fd7ef67508314e2 100644

--- a/pkg/analyzer/lib/src/task/strong/rules.dart

+++ b/pkg/analyzer/lib/src/task/strong/rules.dart

@@ -321,6 +321,10 @@ class TypeRules {

return false;

}

+ if (t1.isVoid || t2.isVoid) {

+ return false;

+ }

if (t2.isDartCoreFunction) {

if (t1 is FunctionType) return true;

if (t1.element is ClassElement) {

« no previous file with comments | « no previous file | pkg/analyzer/test/generated/type_system_test.dart » ('j') | no next file with comments »