Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1497803003: Check for void in rules subtyping (fixes #25069) (Closed)

Created:
5 years ago by Leaf
Modified:
5 years ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M pkg/analyzer/lib/src/task/strong/rules.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/type_system_test.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Leaf
5 years ago (2015-12-03 21:37:11 UTC) #3
Jennifer Messerly
lgtm
5 years ago (2015-12-03 21:40:26 UTC) #4
Leaf
5 years ago (2015-12-03 21:41:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2d61ed26b79f0c047e99c8cc145620d1dd632c85 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698