Implement Array.observe and emit splice change records for ArrayPush

Implement Array.observe and emit splice change records for ArrayPush

Committed: http://code.google.com/p/v8/source/detail?r=14705

[adamk, 2013-05-16 00:45:29]

https://codereview.chromium.org/14978007/diff/3001/src/array.js
File src/array.js (right):

https://codereview.chromium.org/14978007/diff/3001/src/array.js#newcode432
src/array.js:432: 
Nit: no need for this blank line

https://codereview.chromium.org/14978007/diff/3001/src/object-observe.js
File src/object-observe.js (right):

https://codereview.chromium.org/14978007/diff/3001/src/object-observe.js#newc...
src/object-observe.js:306: removed: removed,
Spec question: are we OK with the 'removed' array being mutable? It seems a bit
off to freeze the changeRecord but not the array. Of course, even after I speed
up freeze, frozen arrays will still be slow, so...

[rafaelw, 2013-05-16 01:10:48]

https://codereview.chromium.org/14978007/diff/3001/src/array.js
File src/array.js (right):

https://codereview.chromium.org/14978007/diff/3001/src/array.js#newcode432
src/array.js:432: 
On 2013/05/16 00:45:30, adamk wrote:
> Nit: no need for this blank line

Done.

https://codereview.chromium.org/14978007/diff/3001/src/object-observe.js
File src/object-observe.js (right):

https://codereview.chromium.org/14978007/diff/3001/src/object-observe.js#newc...
src/object-observe.js:306: removed: removed,
I think the answer is probably yes. Arv?

The freezing isn't for security, it's for observers not messing with each other,
(and so we don't need to create one for each observer).

I've added a todo (all freezing is disabled right now). The bummer is that even
with Adamk's work on freezing, frozen array's are likely to be slow, but I think
Adam & Toon have some ideas about this for the future, so maybe there's hope.

On 2013/05/16 00:45:30, adamk wrote:
> Spec question: are we OK with the 'removed' array being mutable? It seems a
bit
> off to freeze the changeRecord but not the array. Of course, even after I
speed
> up freeze, frozen arrays will still be slow, so...

[rossberg, 2013-05-16 10:56:38]

lgtm

[rossberg, 2013-05-16 11:19:44]

Committed patchset #4 manually as r14705 (presubmit successful).