Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 14978003: Improve trace_opt output to help find compilation problems (Closed)

Created:
7 years, 7 months ago by danno
Modified:
7 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Improve trace_opt output to help find compilation problems R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14636

Patch Set 1 #

Patch Set 2 : Add missing newline #

Patch Set 3 : nit #

Patch Set 4 : Platform ports #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -41 lines) Patch
M src/arm/deoptimizer-arm.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.cc View 1 2 4 chunks +7 lines, -13 lines 0 comments Download
M src/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/deoptimizer-mips.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 3 chunks +4 lines, -2 lines 0 comments Download
M src/objects.cc View 9 chunks +64 lines, -11 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/objects-visiting-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime-profiler.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/x64/deoptimizer-x64.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
danno
PTAL
7 years, 7 months ago (2013-05-13 07:26:44 UTC) #1
Jakob Kummerow
LGTM. What about ARM and x64?
7 years, 7 months ago (2013-05-13 11:02:57 UTC) #2
danno
7 years, 7 months ago (2013-05-13 11:10:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r14636 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698