Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1497793002: PPC: [debugger] do not restart frames that reference new.target for liveedit.c (Closed)

Created:
5 years ago by MTBrandyberry
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [debugger] do not restart frames that reference new.target for liveedit.c Port 6fca870240bdbb07a365189b5eb0c98fa65b3682 R=yangguo@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/9290dd825e4e7a0ed7c786b663e885a31bc11350 Cr-Commit-Position: refs/heads/master@{#32589}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/debug/ppc/debug-ppc.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
MTBrandyberry
5 years ago (2015-12-03 16:07:00 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1497793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1497793002/1
5 years ago (2015-12-03 16:07:16 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-03 17:41:08 UTC) #5
john.yan
lgtm
5 years ago (2015-12-03 18:49:55 UTC) #6
MTBrandyberry
On 2015/12/03 18:49:55, john.yan wrote: > lgtm Looks like the original was just reverted so ...
5 years ago (2015-12-03 18:52:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1497793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1497793002/1
5 years ago (2015-12-03 20:25:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 20:27:44 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-03 20:28:02 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9290dd825e4e7a0ed7c786b663e885a31bc11350
Cr-Commit-Position: refs/heads/master@{#32589}

Powered by Google App Engine
This is Rietveld 408576698