Fix optimizations on static fields in precompiled code.

Fix optimizations on static fields in precompiled code.

Don't perform LICM / or load elimination of static fields in precompiled
code since they may not be initialized and we don't record an explicit
dependency between the initialization and the load of a static field.

BUG=
R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/eee0e6d8c34661510b328d3f80c18b4d7755c4b7

[Florian Schneider, 2015-12-03 16:19:51]

fschneider@google.com changed reviewers:
+ rmacnak@google.com

[srdjan, 2015-12-03 16:57:55]

srdjan@google.com changed reviewers:
+ srdjan@google.com

[srdjan, 2015-12-03 16:57:56]

DBC

https://codereview.chromium.org/1497783002/diff/20001/runtime/vm/flow_graph_o...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/1497783002/diff/20001/runtime/vm/flow_graph_o...
runtime/vm/flow_graph_optimizer.cc:5660: && (!field().is_static() ||
!FLAG_fields_may_be_reset);
IMO, the flag does not belong here, the test is for IsFinalField. I suggest
renaming the test method to something like IsImmutableField and add comment what
is going on.

[rmacnak, 2015-12-03 21:09:11]

lgtm

https://codereview.chromium.org/1497783002/diff/20001/runtime/vm/flow_graph_o...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/1497783002/diff/20001/runtime/vm/flow_graph_o...
runtime/vm/flow_graph_optimizer.cc:5660: && (!field().is_static() ||
!FLAG_fields_may_be_reset);
On 2015/12/03 16:57:56, srdjan wrote:
> IMO, the flag does not belong here, the test is for IsFinalField. I suggest
> renaming the test method to something like IsImmutableField and add comment
what
> is going on.

Ditto.

[Florian Schneider, 2015-12-04 11:36:54]

https://codereview.chromium.org/1497783002/diff/20001/runtime/vm/flow_graph_o...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/1497783002/diff/20001/runtime/vm/flow_graph_o...
runtime/vm/flow_graph_optimizer.cc:5660: && (!field().is_static() ||
!FLAG_fields_may_be_reset);
On 2015/12/03 16:57:56, srdjan wrote:
> IMO, the flag does not belong here, the test is for IsFinalField. I suggest
> renaming the test method to something like IsImmutableField and add comment
what
> is going on.

Done.

[Florian Schneider, 2015-12-04 11:42:45]

Description was changed from

==========
Fix optimizations on static fields in precompiled code.

Don't perform LICM / or load elimination of static fields in precompiled
code since they may not be initialized and we don't record an explicit
dependency between the initialization and the load of a static field.

BUG=
==========

to

==========
Fix optimizations on static fields in precompiled code.

Don't perform LICM / or load elimination of static fields in precompiled
code since they may not be initialized and we don't record an explicit
dependency between the initialization and the load of a static field.

BUG=
R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/eee0e6d8c34661510b328d3f80c18b4d7755c4b7
==========

[Florian Schneider, 2015-12-04 11:42:46]

Committed patchset #3 (id:40001) manually as
eee0e6d8c34661510b328d3f80c18b4d7755c4b7 (presubmit successful).