Rietveld: refactor and improve retries with UrlError exception.

Rietveld: refactor and improve retries with UrlError exception.

BUG=564304
R=sergiyb@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297830

[tandrii(chromium), 2015-12-03 14:50:26]

PTAL

[Adrian Kuegel, 2015-12-03 14:53:30]

akuegel@chromium.org changed reviewers:
+ akuegel@chromium.org

[Adrian Kuegel, 2015-12-03 14:53:31]

https://codereview.chromium.org/1497763003/diff/20001/rietveld.py
File rietveld.py (right):

https://codereview.chromium.org/1497763003/diff/20001/rietveld.py#newcode446
rietveld.py:446: 'The handshake operation timed out',
Drive-by: this line seems to be redundant.

[Sergiy Byelozyorov, 2015-12-03 14:54:46]

lgtm

https://codereview.chromium.org/1497763003/diff/20001/rietveld.py
File rietveld.py (right):

https://codereview.chromium.org/1497763003/diff/20001/rietveld.py#newcode443
rietveld.py:443: for retry_anyway in [
return any(str in reason_as_str for str in [...]):

[tandrii(chromium), 2015-12-03 14:58:27]

https://codereview.chromium.org/1497763003/diff/20001/rietveld.py
File rietveld.py (right):

https://codereview.chromium.org/1497763003/diff/20001/rietveld.py#newcode443
rietveld.py:443: for retry_anyway in [
On 2015/12/03 14:54:45, Sergiy Byelozyorov wrote:
> return any(str in reason_as_str for str in [...]):

I found "str in" for "str in" confusing, even though I love list comprehensions,
so will leave as is.

https://codereview.chromium.org/1497763003/diff/20001/rietveld.py#newcode446
rietveld.py:446: 'The handshake operation timed out',
On 2015/12/03 14:53:31, Adrian Kuegel wrote:
> Drive-by: this line seems to be redundant.

Totally!

[tandrii(chromium), 2015-12-03 14:58:31]

The CQ bit was checked by tandrii@chromium.org

[tandrii(chromium), 2015-12-03 14:58:31]

The patchset sent to the CQ was uploaded after l-g-t-m from sergiyb@chromium.org
Link to the patchset: https://codereview.chromium.org/1497763003/#ps40001
(title: "drive-by")

[commit-bot: I haz the power, 2015-12-03 14:58:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1497763003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1497763003/40001

[commit-bot: I haz the power, 2015-12-03 15:00:35]

Description was changed from

==========
Rietveld: refactor and improve retries with UrlError exception.

BUG=564304
R=sergiyb@chromium.org
==========

to

==========
Rietveld: refactor and improve retries with UrlError exception.

BUG=564304
R=sergiyb@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297830
==========

[commit-bot: I haz the power, 2015-12-03 15:00:35]

Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297830