content/browser/frame_host/render_frame_host_impl.cc - Issue 1497743005: Allow huge data: URIs only via WebView.loadDataWithBaseUrl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 1497743005: Allow huge data: URIs only via WebView.loadDataWithBaseUrl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Sort out the tests Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigation_entry_impl.h ('K') | « content/browser/frame_host/navigator_impl.cc ('k') | content/browser/web_contents/web_contents_impl_unittest.cc » ('j') | content/common/navigation_params.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.cc

diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc

index 18a88eb441030f40bbeb1fb55ee33ec8085b8d4f..d0ecd6b425d19e4ddcad303d03c6b10fe8ce0450 100644

--- a/content/browser/frame_host/render_frame_host_impl.cc

+++ b/content/browser/frame_host/render_frame_host_impl.cc

@@ -1878,8 +1878,8 @@ void RenderFrameHostImpl::NavigateToInterstitialURL(const GURL& data_url) {

CommonNavigationParams common_params(

data_url, Referrer(), ui::PAGE_TRANSITION_LINK,

FrameMsg_Navigate_Type::NORMAL, false, false, base::TimeTicks::Now(),

- FrameMsg_UILoadMetricsReportType::NO_REPORT, GURL(), GURL(), LOFI_OFF,

- base::TimeTicks::Now());

+ FrameMsg_UILoadMetricsReportType::NO_REPORT, GURL(), GURL(),

+ std::string(), LOFI_OFF, base::TimeTicks::Now());

if (base::CommandLine::ForCurrentProcess()->HasSwitch(

switches::kEnableBrowserSideNavigation)) {

CommitNavigation(nullptr, nullptr, common_params,