Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2236)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/renderer/render_view_browsertest.cc

Issue 1497743005: Allow huge data: URIs only via WebView.loadDataWithBaseUrl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed the test Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_browsertest.cc
diff --git a/content/renderer/render_view_browsertest.cc b/content/renderer/render_view_browsertest.cc
index e509aa934d94301e2376c21d01c73504999a6284..ba4a34556fbb599898591f14666256524cc65978 100644
--- a/content/renderer/render_view_browsertest.cc
+++ b/content/renderer/render_view_browsertest.cc
@@ -442,7 +442,7 @@ TEST_F(RenderViewImplTest, SaveImageFromDataURL) {
ProcessPendingMessages();
render_thread_->sink().ClearMessages();
- const std::string large_data_url(1024 * 1024 * 10 - 1, 'd');
+ const std::string large_data_url(1024 * 1024 * 20 - 1, 'd');
view()->saveImageFromDataURL(WebString::fromUTF8(large_data_url));
ProcessPendingMessages();
@@ -458,7 +458,7 @@ TEST_F(RenderViewImplTest, SaveImageFromDataURL) {
ProcessPendingMessages();
render_thread_->sink().ClearMessages();
- const std::string exceeded_data_url(1024 * 1024 * 10 + 1, 'd');
+ const std::string exceeded_data_url(1024 * 1024 * 20 + 1, 'd');
view()->saveImageFromDataURL(WebString::fromUTF8(exceeded_data_url));
ProcessPendingMessages();
@@ -542,6 +542,34 @@ TEST_F(RenderViewImplTest, OnNavigationHttpPost) {
EXPECT_EQ(0, memcmp(raw_data, element.data.data(), length));
}
+#if defined(OS_ANDROID)
+TEST_F(RenderViewImplTest, OnNavigationLoadDataWithBaseURL) {
+ CommonNavigationParams common_params;
+ common_params.url = GURL("data:text/html,");
+ common_params.navigation_type = FrameMsg_Navigate_Type::NORMAL;
+ common_params.transition = ui::PAGE_TRANSITION_TYPED;
+ common_params.base_url_for_data_url = GURL("about:blank");
+ common_params.history_url_for_data_url = GURL("about:blank");
+ RequestNavigationParams request_params;
+ request_params.data_url_as_string =
+ "data:text/html,<html><head><title>Data page</title></head></html>";
+
+ frame()->Navigate(common_params, StartNavigationParams(),
+ request_params);
+ const IPC::Message* frame_title_msg = nullptr;
+ do {
+ ProcessPendingMessages();
+ frame_title_msg = render_thread_->sink().GetUniqueMessageMatching(
+ FrameHostMsg_UpdateTitle::ID);
+ } while (!frame_title_msg);
+
+ // Check post data sent to browser matches.
+ FrameHostMsg_UpdateTitle::Param title_params;
+ EXPECT_TRUE(FrameHostMsg_UpdateTitle::Read(frame_title_msg, &title_params));
+ EXPECT_EQ(base::ASCIIToUTF16("Data page"), base::get<0>(title_params));
+}
+#endif
+
TEST_F(RenderViewImplTest, DecideNavigationPolicy) {
WebUITestWebUIControllerFactory factory;
WebUIControllerFactory::RegisterFactory(&factory);
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698