Allow huge data: URIs only via WebView.loadDataWithBaseUrl

content/browser/frame_host/navigation_controller_impl_unittest.cc

Index: content/browser/frame_host/navigation_controller_impl_unittest.cc
diff --git a/content/browser/frame_host/navigation_controller_impl_unittest.cc b/content/browser/frame_host/navigation_controller_impl_unittest.cc
index 35d8319af9c3ce88a3daa0b5f9e2369e90b181e5..fc14e2e29e01a58004b4a53d194ecb23ecfc1f08 100644
--- a/content/browser/frame_host/navigation_controller_impl_unittest.cc
+++ b/content/browser/frame_host/navigation_controller_impl_unittest.cc
@@ -540,6 +540,7 @@ void CheckNavigationEntryMatchLoadParams(
   if (!load_params.virtual_url_for_data_url.is_empty()) {
     EXPECT_EQ(load_params.virtual_url_for_data_url, entry->GetVirtualURL());
   }
+  EXPECT_EQ(load_params.data_url_as_string, entry->GetDataURLAsString());

[Charlie Reis, 2015/12/10 20:43:46]

Can we also check that if data_url_as_string is specified, that GetURL is a
prefix of it?

[mnaganov (inactive), 2015/12/11 23:14:23]

I added checks into navigation_controller_android (as not it's Android-specific
code). I think, we don't need to check for prefix, as the main point is that
GetURL needs to have empty data.

   if (NavigationController::UA_OVERRIDE_INHERIT !=
       load_params.override_user_agent) {
     bool should_override = (NavigationController::UA_OVERRIDE_TRUE ==
@@ -587,6 +588,7 @@ TEST_F(NavigationControllerTest, LoadURLWithExtraParams_Data) {
   load_params.load_type = NavigationController::LOAD_TYPE_DATA;
   load_params.base_url_for_data_url = GURL("http://foo");
   load_params.virtual_url_for_data_url = GURL(url::kAboutBlankURL);
+  load_params.data_url_as_string = "data:text/html;charset=utf-8;base64,";

[Charlie Reis, 2015/12/10 20:43:46]

Why doesn't this match the specified URL (data:text/html,dataurl)?

[mnaganov (inactive), 2015/12/11 23:14:23]

Done.

   load_params.override_user_agent = NavigationController::UA_OVERRIDE_FALSE;
 
   controller.LoadURLWithParams(load_params);