Allow huge data: URIs only via WebView.loadDataWithBaseUrl

content/browser/frame_host/navigation_entry_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_
 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_
 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_vector.h"
@@ skipping 64 matching lines @@
                       bool is_renderer_initiated);
   ~NavigationEntryImpl() override;
 
   // NavigationEntry implementation:
   int GetUniqueID() const override;
   PageType GetPageType() const override;
   void SetURL(const GURL& url) override;
   const GURL& GetURL() const override;
   void SetBaseURLForDataURL(const GURL& url) override;
   const GURL& GetBaseURLForDataURL() const override;
+  void SetDataURLAsString(const std::string& url) override;

[Charlie Reis, 2015/12/10 20:43:46]

boliu@ and I spent a lot of time avoiding a new member for the data URL for
https://crbug.com/522567.  I'm sad that we're having to add it (as he predicted
in https://code.google.com/p/chromium/issues/detail?id=525697#c18).

This seems like one more way for NavigationEntries to have inconsistent
information (e.g., this vs GetURL), with subtle bugs if they aren't populated
correctly or checked consistently.

[mnaganov (inactive), 2015/12/11 23:14:23]

I hope I added enough checks to enforce consistency.

We could get rid of the base URL field (put its contents into the main URL
field). But as I'm now making 'DataURLAsString' to be specific to Android, this
will not be possible.

+  const std::string& GetDataURLAsString() const override;
   void SetReferrer(const Referrer& referrer) override;
   const Referrer& GetReferrer() const override;
   void SetVirtualURL(const GURL& url) override;
   const GURL& GetVirtualURL() const override;
   void SetTitle(const base::string16& title) override;
   const base::string16& GetTitle() const override;
   void SetPageState(const PageState& state) override;
   PageState GetPageState() const override;
   void SetPageID(int page_id) override;
   int32 GetPageID() const override;
@@ skipping 318 matching lines @@
   // This member is not persisted with session restore.
   std::string extra_headers_;
 
   // This member is cleared in |ResetForCommit| and not persisted.
   scoped_refptr<SiteInstanceImpl> source_site_instance_;
 
   // Used for specifying base URL for pages loaded via data URLs. Only used and
   // persisted by Android WebView.
   GURL base_url_for_data_url_;
 
+  // Used for passing really big data URLs from browser to renderers. Only used
+  // and persisted by Android WebView.

[Charlie Reis, 2015/12/10 20:43:46]

I'm concerned about the "only Android WebView" comment without having it in an
#ifdef.  The rest of the LoadDataForBaseURL feature leaked to the Chrome Apps
<webview> implementation, so these comments aren't enforceable lead to uses of
this bad API in other parts of Chrome.

If we keep this, can we put it (and the new methods) in an #ifdef?  I don't
think we want to support this hack for LoadDataForBaseURL inside Chrome Apps
<webview>.

[mnaganov (inactive), 2015/12/11 23:14:23]

Now it's enforced by OS_ANDROID defines.

+  std::string data_url_as_string_;

[Charlie Reis, 2015/12/10 20:43:46]

I'd like to consider alternatives to this if we can, as I mention in my overall
CL comment.

[mnaganov (inactive), 2015/12/11 23:14:23]

Considered.

+
   // Whether the entry, while loading, was created for a renderer-initiated
   // navigation.  This dictates whether the URL should be displayed before the
   // navigation commits.  It is cleared in |ResetForCommit| and not persisted.
   bool is_renderer_initiated_;
 
   // This is a cached version of the result of GetTitleForDisplay. It prevents
   // us from having to do URL formatting on the URL every time the title is
   // displayed. When the URL, virtual URL, or title is set, this should be
   // cleared to force a refresh.
   mutable base::string16 cached_display_title_;
@@ skipping 55 matching lines @@
   // persisted, unless specific data is taken out/put back in at save/restore
   // time (see TabNavigation for an example of this).
   std::map<std::string, base::string16> extra_data_;
 
   DISALLOW_COPY_AND_ASSIGN(NavigationEntryImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_