Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 149773006: Move the android library loader from content to base (Closed)

Created:
6 years, 10 months ago by Noel Gordon
Modified:
6 years, 10 months ago
Reviewers:
Yaron
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Move the android library loader from content to base Follow on r250113, which added a base.gypi dependency on unused files results_codes.h, results_codes_list.h. The files are unused so remove them from base.gypi (stops gclient runhooks complaining that they are missing files). BUG=225101 TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250705

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M base/base.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Noel Gordon
6 years, 10 months ago (2014-02-12 01:44:11 UTC) #1
Yaron
lgtm
6 years, 10 months ago (2014-02-12 01:48:08 UTC) #2
Noel Gordon
The CQ bit was checked by noel@chromium.org
6 years, 10 months ago (2014-02-12 01:50:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noel@chromium.org/149773006/1
6 years, 10 months ago (2014-02-12 01:50:58 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-12 05:31:50 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, ...
6 years, 10 months ago (2014-02-12 05:31:51 UTC) #6
Noel Gordon
The CQ bit was checked by noel@chromium.org
6 years, 10 months ago (2014-02-12 07:11:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noel@chromium.org/149773006/1
6 years, 10 months ago (2014-02-12 07:14:11 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-12 08:46:50 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=262364
6 years, 10 months ago (2014-02-12 08:46:51 UTC) #10
Noel Gordon
The CQ bit was checked by noel@chromium.org
6 years, 10 months ago (2014-02-12 11:49:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noel@chromium.org/149773006/1
6 years, 10 months ago (2014-02-12 11:49:54 UTC) #12
commit-bot: I haz the power
6 years, 10 months ago (2014-02-12 13:48:32 UTC) #13
Message was sent while issue was closed.
Change committed as 250705

Powered by Google App Engine
This is Rietveld 408576698