Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 149773004: Add use counters for EventSource.URL, WebSocket.URL. (Closed)

Created:
6 years, 10 months ago by sof
Modified:
6 years, 10 months ago
CC:
blink-reviews, eae+blinkwatch, dglazkov+blink, arv+blink, Inactive, watchdog-blink-watchlist_google.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add use counters for EventSource.URL, WebSocket.URL. These two properties (in their uppercased form) are an accident of spec history. Add use counters to gauge if the process of retirement can be started. R=jochen@chromium.org BUG=249727 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166400

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M Source/core/frame/UseCounter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/page/EventSource.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/WebSocket.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
sof
When you next have a spare moment, please take a look. I hope we can ...
6 years, 10 months ago (2014-02-04 11:58:06 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 10 months ago (2014-02-04 12:15:37 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 10 months ago (2014-02-04 12:16:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/149773004/1
6 years, 10 months ago (2014-02-04 12:16:56 UTC) #4
commit-bot: I haz the power
Change committed as 166400
6 years, 10 months ago (2014-02-04 14:02:48 UTC) #5
skia-commit-bot
6 years, 10 months ago (2014-02-04 14:02:50 UTC) #6
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698