Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1450)

Issue 14977015: Re-land Notifier.prototype.performChange + tests (Closed)

Created:
7 years, 7 months ago by rafaelw
Modified:
7 years, 7 months ago
Reviewers:
rossberg, adamk
CC:
v8-dev
Visibility:
Public.

Description

Re-land Notifier.prototype.performChange + tests Fixes the debug check failure on sorting an object with an array __proto__. Original Issue: https://codereview.chromium.org/14779011/ TBR=adamk@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14698

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+515 lines, -32 lines) Patch
M src/messages.js View 1 chunk +3 lines, -0 lines 0 comments Download
M src/object-observe.js View 7 chunks +183 lines, -11 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/object-observe.js View 9 chunks +328 lines, -20 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rafaelw
7 years, 7 months ago (2013-05-15 21:57:49 UTC) #1
adamk
lgtm, landing TBR rossberg (one line fix)
7 years, 7 months ago (2013-05-15 21:59:35 UTC) #2
adamk
7 years, 7 months ago (2013-05-15 22:09:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14698 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698