Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 1497643002: Disables all WindowManagerAppTest as they are flakey (Closed)

Created:
5 years ago by sky
Modified:
5 years ago
Reviewers:
jam
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disables all WindowManagerAppTest as they are flakey My first attempt was reverted as disabling the only test in a harness caused problems with the script that runs the tests. My early attempt didn't trigger try runs because script that determines when to run apptests needed to be updated. I'm doing that here too. BUG=559412 TEST=none R=jam@chromium.org Committed: https://crrev.com/e4c13c065e29b67a160f67dba211bab5c956afe6 Cr-Commit-Position: refs/heads/master@{#363091}

Patch Set 1 #

Patch Set 2 : disable all tests #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -9 lines) Patch
M mash/BUILD.gn View 1 chunk +9 lines, -1 line 0 comments Download
M mash/wm/window_manager_apptest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/tools/data/apptests View 1 1 chunk +7 lines, -6 lines 0 comments Download
M testing/scripts/mojo_apptests.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
sky
5 years ago (2015-12-03 20:25:41 UTC) #2
jam
lgtm
5 years ago (2015-12-03 22:06:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1497643002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1497643002/40001
5 years ago (2015-12-03 22:08:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) win_chromium_compile_dbg_ng on ...
5 years ago (2015-12-04 00:27:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1497643002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1497643002/40001
5 years ago (2015-12-04 00:40:04 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-04 02:43:32 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-04 02:44:54 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e4c13c065e29b67a160f67dba211bab5c956afe6
Cr-Commit-Position: refs/heads/master@{#363091}

Powered by Google App Engine
This is Rietveld 408576698