Plugin Power Saver: Improve Poster behavior for essential plugins.

content/renderer/peripheral_content_heuristic.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/peripheral_content_heuristic.h"
 
 #include <cmath>
 
 namespace content {
 
@@ skipping 22 matching lines @@
 PeripheralContentHeuristic::Decision
 PeripheralContentHeuristic::GetPeripheralStatus(
     const std::set<url::Origin>& origin_whitelist,
     const url::Origin& main_frame_origin,
     const url::Origin& content_origin,
     int width,
     int height) {
   if (main_frame_origin.IsSameOriginWith(content_origin))
     return HEURISTIC_DECISION_ESSENTIAL_SAME_ORIGIN;
 
+  if (origin_whitelist.count(content_origin))

[groby-ooo-7-16, 2015/12/04 22:06:56]

Since order matters, probably worth having either a comment here, or a test that
checks we have the proper ordering.

[tommycli, 2015/12/07 22:06:18]

Sounds good. I added a test.

+    return HEURISTIC_DECISION_ESSENTIAL_CROSS_ORIGIN_WHITELISTED;
+
   if (width <= 0 || height <= 0)
     return HEURISTIC_DECISION_ESSENTIAL_UNKNOWN_SIZE;
 
-  if (origin_whitelist.count(content_origin))
-    return HEURISTIC_DECISION_ESSENTIAL_CROSS_ORIGIN_WHITELISTED;
-
   if (width <= kTinyContentSize && height <= kTinyContentSize)
     return HEURISTIC_DECISION_ESSENTIAL_CROSS_ORIGIN_TINY;
 
   if (IsLargeContent(width, height))
     return HEURISTIC_DECISION_ESSENTIAL_CROSS_ORIGIN_BIG;
 
   return HEURISTIC_DECISION_PERIPHERAL;
 }
 
 // static
 bool PeripheralContentHeuristic::IsLargeContent(int width, int height) {
   if (width >= kLargeContentMinWidth && height >= kLargeContentMinHeight)
     return true;
 
   double aspect_ratio = static_cast<double>(width) / height;
   if (std::abs(aspect_ratio - kEssentialVideoAspectRatio) <
           kAspectRatioEpsilon &&
       width * height >= kEssentialVideoMinimumArea) {
     return true;
   }
 
   return false;
 }
 
 }  // namespace content