Plugin Power Saver: Improve Poster behavior for essential plugins.

content/public/renderer/render_frame.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_RENDERER_RENDER_FRAME_H_
 #define CONTENT_PUBLIC_RENDERER_RENDER_FRAME_H_
 
 #include "base/callback_forward.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string16.h"
@@ skipping 128 matching lines @@
   // Plugin content is defined to be cross-origin when the plugin source's
   // origin differs from the top level frame's origin. For example:
   //  - Cross-origin:  a.com -> b.com/plugin.swf
   //  - Cross-origin:  a.com -> b.com/iframe.html -> b.com/plugin.swf
   //  - Same-origin:   a.com -> b.com/iframe-to-a.html -> a.com/plugin.swf
   //
   // |main_frame_origin| is the origin of the main frame.
   //
   // |content_origin| is the origin of the plugin content.
   //
   // |width| and |height| are zoom and device scale independent logical pixels.

[groby-ooo-7-16, 2015/12/04 22:06:56]

Can we make this gfx::Size?

And we probably want to ignore the sizing if it's empty (i.e. 0x0), unless
there's a specific reason to have 0x0 logical pixels?

[tommycli, 2015/12/07 22:06:18]

Done. Yeah that's a good idea. That way I can use an empty gfx::Size (0x0) as
the sentinel value indicating unknown size.

This also exposes another issue that I have filed a separate bug for:
https://code.google.com/p/chromium/issues/detail?id=566194&can=3&colspec=ID%2...

[groby-ooo-7-16, 2015/12/07 22:16:04]

Careful - it _might_ be we need to treat 0x0 plugins differently. I don't think
we do, but it's worth considering that.

[tommycli, 2015/12/07 22:22:13]

Yeah this comment has gone away. Currently, 0x0 plugins are exempted via
CONTENT_STATUS_ESSENTIAL_UNKNOWN_SIZE.

Since we switched to gfx::Size, (which is nice actually), there is no such thing
as negative sizing. Any negative dimension gets zeroed.

+  // If they are negative, the sizing is ignored, and the method returns false
+  // if and only if the origin marks the content as essential.
   //
   // |cross_origin_main_content| may be NULL. It is set to true if the
   // plugin content is cross-origin but still the "main attraction" of the page.
   virtual bool ShouldThrottleContent(const url::Origin& main_frame_origin,
                                      const url::Origin& content_origin,
                                      int width,
                                      int height,
                                      bool* cross_origin_main_content) const = 0;
 
   // Whitelists a |content_origin| so its content will never be throttled in
@@ skipping 34 matching lines @@
 
  private:
   // This interface should only be implemented inside content.
   friend class RenderFrameImpl;
   RenderFrame() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_RENDERER_RENDER_FRAME_H_