Plugin Power Saver: Improve Poster behavior for essential plugins.

components/plugins/renderer/loadable_plugin_placeholder.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/plugins/renderer/loadable_plugin_placeholder.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/json/string_escape.h"
 #include "base/strings/string_piece.h"
@@ skipping 163 matching lines @@
   // Pass through JavaScript access to the underlying throttled plugin.
   if (premade_throttler_ && premade_throttler_->GetWebPlugin()) {
     return premade_throttler_->GetWebPlugin()->v8ScriptableObject(isolate);
   }
   return v8::Local<v8::Object>();
 }
 
 void LoadablePluginPlaceholder::OnUnobscuredRectUpdate(
     const gfx::Rect& unobscured_rect) {
   DCHECK(content::RenderThread::Get());
-  if (!power_saver_enabled_ || !finished_loading_)
+  if (!power_saver_enabled_ || !finished_loading_) {
     return;
+  }

[groby-ooo-7-16, 2015/12/04 22:06:56]

??

[tommycli, 2015/12/07 22:06:18]

Done.

 
   // Only update the unobscured rect during the recheck phase. Also early exit
   // to prevent reentrancy issues.
   if (in_size_recheck_) {
     unobscured_rect_ = unobscured_rect;
     return;
   }
 
   if (!size_update_timer_.IsRunning()) {
     // TODO(tommycli): We have to post a delayed task to recheck the size, as
@@ skipping 66 matching lines @@
 
 void LoadablePluginPlaceholder::DidFinishLoadingCallback() {
   finished_loading_ = true;
   if (message_.length() > 0)
     UpdateMessage();
 
   // Wait for the placeholder to finish loading to hide the premade plugin.
   // This is necessary to prevent a flicker.
   if (premade_throttler_ && power_saver_enabled_)
     premade_throttler_->SetHiddenForPlaceholder(true /* hidden */);
+
+  // In case our initial geometry was reported before the placeholder finished
+  // loading, request another one. Needed for correct large poster unthrottling.

[groby-ooo-7-16, 2015/12/04 22:06:56]

Is it, even if large posters don't get throttled?

[tommycli, 2015/12/07 22:06:18]

Yes, as large posters are throttled, and then become unthrottled.

This is because we can't tell a plugin's actual size until after a placeholder
plugin is placed onto the page and we get a geometry update.

[groby-ooo-7-16, 2015/12/07 22:16:04]

That's... limited happiness. Will that mean poster images will always flash,
even if the thing is clearly large size? Doesn't that mean that poster= is then
a worse experience than just loading the swf and letting us determine the image?

[tommycli, 2015/12/07 22:22:13]

This patch makes the "flash" imperceptible on my machine. I will send it to you
after this one finishes. https://codereview.chromium.org/1491893004/

+  plugin()->container()->reportGeometry();
 }
 
 void LoadablePluginPlaceholder::DidFinishIconRepositionForTestingCallback() {
   // Set an attribute and post an event, so browser tests can wait for the
   // placeholder to be ready to receive simulated user input.
   blink::WebElement element = plugin()->container()->element();
   element.setAttribute("placeholderReady", "true");
 
   scoped_ptr<content::V8ValueConverter> converter(
       content::V8ValueConverter::create());
@@ skipping 79 matching lines @@
         render_frame()->WhitelistContentOrigin(content_origin);
     }
 
     heuristic_run_before_ = true;
   }
 
   in_size_recheck_ = false;
 }
 
 }  // namespace plugins