Plugin Power Saver: Improve Poster behavior for essential plugins.

chrome/renderer/chrome_content_renderer_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_content_renderer_client.h"
 
 #include "base/command_line.h"
 #include "base/debug/crash_logging.h"
 #include "base/logging.h"
 #include "base/metrics/field_trial.h"
@@ skipping 806 matching lines @@
             is_flash || override_for_testing == "ignore-list";
 
         bool power_saver_setting_on =
             status ==
             ChromeViewHostMsg_GetPluginInfo_Status::kPlayImportantContent;
 
         bool power_saver_enabled =
             override_for_testing == "always" ||
             (power_saver_setting_on && can_throttle_plugin_type);
         bool blocked_for_background_tab =
             power_saver_enabled && render_frame->IsHidden();

[groby-ooo-7-16, 2015/12/04 22:06:56]

Don't we need to fix up power_saver_enabled before we check
blocked_for_background_tab?

[tommycli, 2015/12/07 22:06:18]

Hmm... actually I think the ordering here is correct, since we should still
defer background-tab same-origin content.

I added a comment to that effect.

[groby-ooo-7-16, 2015/12/07 22:16:04]

Wait - we defer even same-origin on the background tab?

[tommycli, 2015/12/07 22:22:13]

Yep. Same behavior on VIDEO tag now too. The plugin is not loaded until you
foreground the tab for the first time.

 
         PlaceholderPosterInfo poster_info;
         if (power_saver_enabled) {
-          poster_info.poster_attribute =
-              GetPluginInstancePosterAttribute(params);
-          poster_info.base_url = frame->document().url();
+          bool essential_origin = !render_frame->ShouldThrottleContent(
+              render_frame->GetWebFrame()->top()->securityOrigin(),
+              url::Origin(params.url), -1, -1, nullptr);

[groby-ooo-7-16, 2015/12/04 22:06:56]

Ugh. Three mystery params. 

[tommycli, 2015/12/07 22:06:18]

Done.

+
+          if (essential_origin) {
+            // Turn off power saver and ignore poster for same-origin and
+            // whitelisted-origin plugin content.
+            power_saver_enabled = false;
+          } else {
+            poster_info.poster_attribute =
+                GetPluginInstancePosterAttribute(params);
+            poster_info.base_url = frame->document().url();
+          }

[groby-ooo-7-16, 2015/12/04 22:06:56]

In general, that's a whole chunk of code just dealing with PPS, and this
function is already atrociously long - factor out?

[tommycli, 2015/12/07 22:06:18]

Done.

         }
 
         if (is_flash)
           TrackPosterParamPresence(params, power_saver_enabled);
 
         if (blocked_for_background_tab || is_prerendering ||
             !poster_info.poster_attribute.empty()) {
           placeholder = ChromePluginPlaceholder::CreateBlockedPlugin(
               render_frame, frame, params, info, identifier, group_name,
               poster_info.poster_attribute.empty() ? IDR_BLOCKED_PLUGIN_HTML
@@ skipping 637 matching lines @@
 // chrome.system.network.getNetworkInterfaces provides the same
 // information. Also, the enforcement of sending and binding UDP is already done
 // by chrome extension permission model.
 bool ChromeContentRendererClient::ShouldEnforceWebRTCRoutingPreferences() {
 #if defined(ENABLE_EXTENSIONS)
   return !IsStandaloneExtensionProcess();
 #else
   return true;
 #endif
 }