Issue 149760: Introduce WebLocalizedString and queryLocalizedString methods...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149760: Introduce WebLocalizedString and queryLocalizedString methods... (Closed)

Created:
11 years, 5 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
dglazkov

CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Introduce WebLocalizedString and queryLocalizedString methods on WebKitClient. This allows glue/localized_strings.cc to move into the WebKit API implementation. BUG=16933 TEST=none R=dglazkov Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20938

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+379 lines, -365 lines)			Patch
M	chrome/browser/renderer_host/render_sandbox_host_linux.cc	View		4 chunks	+11 lines, -4 lines	0 comments	Download
M	chrome/renderer/renderer_webkitclient_impl.h	View	1 2	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/renderer/renderer_webkitclient_impl.cc	View	1 2	2 chunks	+12 lines, -12 lines	0 comments	Download
M	webkit/api/public/WebKitClient.h	View	1 2	4 chunks	+11 lines, -4 lines	0 comments	Download
A	webkit/api/public/WebLocalizedString.h	View		1 chunk	+66 lines, -0 lines	0 comments	Download
A +	webkit/api/src/LocalizedStrings.cpp	View		1 chunk	+184 lines, -136 lines	0 comments	Download
D	webkit/glue/localized_strings.cc	View	1 2	1 chunk	+0 lines, -193 lines	0 comments	Download
M	webkit/glue/password_autocomplete_listener.h	View	1 2	1 chunk	+4 lines, -8 lines	0 comments	Download
M	webkit/glue/password_autocomplete_listener.cc	View	1 2	1 chunk	+5 lines, -1 line	0 comments	Download
M	webkit/glue/webframe_impl.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/glue/webkitclient_impl.h	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	webkit/glue/webkitclient_impl.cc	View	1 2	3 chunks	+73 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_webkit_init.h	View	1 2	2 chunks	+5 lines, -5 lines	0 comments	Download
M	webkit/webkit.gyp	View	1 2	3 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages