Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 1497583003: Revert of [CQ] Update proto format to fix triggered builders. (Closed)

Created:
5 years ago by Michael Achenbach
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [CQ] Update proto format to fix triggered builders. (patchset #1 id:1 of https://codereview.chromium.org/1494103002/ ) Reason for revert: Still not working... Original issue's description: > Reland of [CQ] Update proto format to fix triggered builders. > > Reason for revert: > > Should be fixed after > https://chromereviews.googleplex.com/317197013/ > https://codereview.chromium.org/1487413002/ > https://codereview.chromium.org/1489293003/ > > TBR=sergiyb@chromium.org,tandrii@chromium.org > NOPRESUBMIT=true > NOTRY=true > BUG=chromium:561530 > > Committed: https://crrev.com/224c7fa72b8002348bb876ab7a4d4fabbf9438a4 > Cr-Commit-Position: refs/heads/master@{#32544} TBR=sergiyb@chromium.org,tandrii@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:561530 Committed: https://crrev.com/5cdb107f88614e624839dcd79b5324952e4cd510 Cr-Commit-Position: refs/heads/master@{#32546}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M infra/config/cq.cfg View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Michael Achenbach
Created Revert of [CQ] Update proto format to fix triggered builders.
5 years ago (2015-12-03 09:42:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1497583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1497583003/1
5 years ago (2015-12-03 09:42:52 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 09:43:14 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5cdb107f88614e624839dcd79b5324952e4cd510 Cr-Commit-Position: refs/heads/master@{#32546}
5 years ago (2015-12-03 09:43:27 UTC) #5
Michael Achenbach
Hung again. E.g. didn't find https://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng_triggered/builds/200 with buildbucket id 9027467389661938368
5 years ago (2015-12-03 09:44:25 UTC) #6
Michael Achenbach
Reason: https://paste.googleplex.com/4707110646448128 :/ :/ :/
5 years ago (2015-12-03 09:54:14 UTC) #7
Michael Achenbach
5 years ago (2015-12-03 12:53:45 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1494893003/ by machenbach@chromium.org.

The reason for reverting is: Should be fixed after
https://chromereviews.googleplex.com/318207014/.

Powered by Google App Engine
This is Rietveld 408576698