Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 1497573002: Fix erroneous restoration of task model state. (Closed)

Created:
5 years ago by Paul Berry
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix erroneous restoration of task model state. The test suite PoorMansIncrementalResolutionTest was turning on the new task model during setup and turning it off during teardown; as a result, any tests run after it were using the old task model. The easy fix is to just stop trying to adjust the task model state in this test suite, since the new task model is on by default now. This should fix test breakages when run via pkg/analyzer/test_all.dart. TBR=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/c030056158b1e190eb806b175e844af38e6f8dcd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Paul Berry
Committed patchset #1 (id:1) manually as c030056158b1e190eb806b175e844af38e6f8dcd (presubmit successful).
5 years ago (2015-12-02 19:41:19 UTC) #2
scheglov
5 years ago (2015-12-02 19:46:54 UTC) #3
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698