Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: sandbox/linux/BUILD.gn

Issue 1497543006: GN: Build nacl_helper_nonsfi unit tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Define _run target for GYP compatibility Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/nacl/loader/nonsfi/nonsfi_sandbox_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/linux/BUILD.gn
diff --git a/sandbox/linux/BUILD.gn b/sandbox/linux/BUILD.gn
index 516342513bccb9387c5235f02a728a8e48dd3e41..b3851be4e3c3d4e70ce0a40044536002e94ac402 100644
--- a/sandbox/linux/BUILD.gn
+++ b/sandbox/linux/BUILD.gn
@@ -65,7 +65,7 @@ source_set("sandbox_linux_test_utils") {
"//testing/gtest",
]
- if (use_seccomp_bpf) {
+ if (use_seccomp_bpf || is_nacl_nonsfi) {
jln (very slow on Chromium) 2015/12/08 23:36:50 nit: it would be better if is_nacl_nonsfi would im
Petr Hosek 2015/12/09 00:51:28 OK, I'd rather do that as a separate change once w
sources += [
"seccomp-bpf/bpf_tester_compatibility_delegate.h",
"seccomp-bpf/bpf_tests.h",
@@ -79,6 +79,13 @@ source_set("sandbox_linux_test_utils") {
deps += [ "//base/test:test_support" ]
defines = [ "SANDBOX_USES_BASE_TEST_SUITE" ]
}
+
+ if (is_nacl_nonsfi) {
+ sources -= [
jln (very slow on Chromium) 2015/12/08 23:36:50 I'm a bit alergic to removing files, it makes thin
Petr Hosek 2015/12/09 00:51:28 Done.
+ "tests/test_utils.cc",
+ "tests/test_utils.h",
+ ]
+ }
}
# Sources for sandbox_linux_unittests.
« no previous file with comments | « components/nacl/loader/nonsfi/nonsfi_sandbox_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698