Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2678)

Unified Diff: base/json/BUILD.gn

Issue 1497543006: GN: Build nacl_helper_nonsfi unit tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code review feedback incorporated Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | base/test/BUILD.gn » ('j') | base/test/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/json/BUILD.gn
diff --git a/base/json/BUILD.gn b/base/json/BUILD.gn
index 70830c15e55d583b71bd25de188855edee898914..8901cbb894a67578e6c861ff976275d3b491a2e9 100644
--- a/base/json/BUILD.gn
+++ b/base/json/BUILD.gn
@@ -2,6 +2,8 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import("//build/config/nacl/config.gni")
Dirk Pranke 2015/12/04 00:22:41 why is this import needed?
Petr Hosek 2015/12/04 05:57:46 This is needed for is_nacl and is_nacl_nonsfi.
+
source_set("json") {
sources = [
"json_file_value_serializer.cc",
@@ -20,13 +22,6 @@ source_set("json") {
"string_escape.h",
]
- if (is_nacl) {
- sources -= [
- "json_file_value_serializer.cc",
- "json_file_value_serializer.h",
- ]
- }
-
configs += [ "//base:base_implementation" ]
deps = [
« no previous file with comments | « BUILD.gn ('k') | base/test/BUILD.gn » ('j') | base/test/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698