Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1497543003: Format all BUILD.gn with "gn format --in-place". (Closed)

Created:
5 years ago by sdefresne
Modified:
5 years ago
CC:
Aaron Boodman, abarth-chromium, asvitkine+watch_chromium.org, ben+mojo_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, chromium-reviews, chromoting-reviews_chromium.org, darin (slow to review), extensions-reviews_chromium.org, fgalligan1, wwcv, jzern, maxbogue+watch_chromium.org, penghuang+watch-mandoline_chromium.org, piman+watch_chromium.org, plaree+watch_chromium.org, pvalenzuela+watch_chromium.org, qsr+mojo_chromium.org, rjkroege, scheib+watch_chromium.org, tfarina, tim+watch_chromium.org, Tom Finegan, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-format-sort-deps
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Format all BUILD.gn with "gn format --in-place". Patch generated by the following command line: $ git ls-files "*.gn" "*.gni" | grep -v format_test_data | sed "s/^/gn format --in-place /"|sh BUG=554928 R=dpranke@chromium.org,scottmg@chromium.org,brettw@chromium.org Committed: https://crrev.com/79adad4e7973e44df1ee34b4952c2bfade88ee01 Cr-Commit-Position: refs/heads/master@{#363370}

Patch Set 1 #

Patch Set 2 : Re-run the script #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M components/nacl/BUILD.gn View 1 2 2 chunks +1 line, -1 line 0 comments Download
M components/variations/BUILD.gn View 1 3 chunks +3 lines, -3 lines 0 comments Download
M mandoline/ui/desktop_ui/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M sync/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/BUILD.gn View 1 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/boringssl/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/cacheinvalidation/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/libvpx_new/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/example/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 28 (12 generated)
sdefresne
Is the sort order correct this time?
5 years ago (2015-12-02 18:44:39 UTC) #2
Dirk Pranke
On 2015/12/02 18:44:39, sdefresne wrote: > Is the sort order correct this time? No :) ...
5 years ago (2015-12-02 18:54:32 UTC) #3
sdefresne
Updated too.
5 years ago (2015-12-02 19:59:02 UTC) #4
Dirk Pranke
lgtm
5 years ago (2015-12-02 21:26:58 UTC) #6
scottmg
lgtm
5 years ago (2015-12-02 22:09:34 UTC) #7
sdefresne
TBR brettw so we can land this once new version of gn is deployed.
5 years ago (2015-12-03 09:33:33 UTC) #10
brettw
rs lgtm
5 years ago (2015-12-03 17:56:56 UTC) #11
brettw
rs lgtm
5 years ago (2015-12-03 17:56:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1497543003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1497543003/20001
5 years ago (2015-12-04 17:14:16 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/150189)
5 years ago (2015-12-04 17:39:36 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1497543003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1497543003/20001
5 years ago (2015-12-04 20:37:27 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/150348)
5 years ago (2015-12-04 21:16:07 UTC) #20
tfarina
I think you will have to rebase.
5 years ago (2015-12-04 21:16:51 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1497543003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1497543003/40001
5 years ago (2015-12-06 12:38:29 UTC) #25
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-06 13:49:04 UTC) #26
commit-bot: I haz the power
5 years ago (2015-12-06 13:49:54 UTC) #28
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/79adad4e7973e44df1ee34b4952c2bfade88ee01
Cr-Commit-Position: refs/heads/master@{#363370}

Powered by Google App Engine
This is Rietveld 408576698