Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 149753002: Enables the 'hotword not listening' icon in the search box. (Closed)

Created:
6 years, 10 months ago by Jun Mukai
Modified:
6 years, 10 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, arv+watch_chromium.org
Visibility:
Public.

Description

Enables the 'hotword not listening' icon in the search box. This CL depends on https://codereview.chromium.org/145353016/ BUG=313904 R=xiyuan@chromium.org TBR=oshima@chromium.org TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248702

Patch Set 1 #

Patch Set 2 : fix on initial state #

Patch Set 3 : fix tooltip text #

Patch Set 4 : re-upload #

Total comments: 4

Patch Set 5 : fix #

Patch Set 6 : fix breaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -58 lines) Patch
M ash/shell/app_list.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/resources/app_list/speech_manager.js View 9 chunks +23 lines, -11 lines 0 comments Download
M chrome/browser/resources/app_list/start_page.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_view_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_view_delegate.cc View 1 2 3 4 5 chunks +15 lines, -4 lines 0 comments Download
M chrome/browser/ui/app_list/search/search_controller.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/app_list/start_page_handler.cc View 1 chunk +10 lines, -4 lines 0 comments Download
M ui/app_list/search_box_model.h View 3 chunks +21 lines, -10 lines 0 comments Download
M ui/app_list/search_box_model.cc View 2 chunks +11 lines, -7 lines 0 comments Download
M ui/app_list/speech_ui_model.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/speech_ui_model.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M ui/app_list/speech_ui_model_observer.h View 1 chunk +5 lines, -2 lines 0 comments Download
M ui/app_list/test/app_list_test_view_delegate.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M ui/app_list/views/app_list_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/app_list/views/search_box_view.h View 3 chunks +7 lines, -1 line 0 comments Download
M ui/app_list/views/search_box_view.cc View 4 chunks +21 lines, -4 lines 0 comments Download
M ui/app_list/views/speech_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (0 generated)
Jun Mukai
6 years, 10 months ago (2014-01-30 00:05:08 UTC) #1
xiyuan
lgtm https://codereview.chromium.org/149753002/diff/60001/chrome/browser/ui/app_list/app_list_view_delegate.cc File chrome/browser/ui/app_list/app_list_view_delegate.cc (right): https://codereview.chromium.org/149753002/diff/60001/chrome/browser/ui/app_list/app_list_view_delegate.cc#newcode102 chrome/browser/ui/app_list/app_list_view_delegate.cc:102: nit: nuke one empty line https://codereview.chromium.org/149753002/diff/60001/chrome/browser/ui/app_list/app_list_view_delegate.cc#newcode109 chrome/browser/ui/app_list/app_list_view_delegate.cc:109: app_list::SPEECH_RECOGNITION_HOTWORD_LISTENING ...
6 years, 10 months ago (2014-01-30 00:27:44 UTC) #2
Jun Mukai
https://codereview.chromium.org/149753002/diff/60001/chrome/browser/ui/app_list/app_list_view_delegate.cc File chrome/browser/ui/app_list/app_list_view_delegate.cc (right): https://codereview.chromium.org/149753002/diff/60001/chrome/browser/ui/app_list/app_list_view_delegate.cc#newcode102 chrome/browser/ui/app_list/app_list_view_delegate.cc:102: On 2014/01/30 00:27:45, xiyuan wrote: > nit: nuke one ...
6 years, 10 months ago (2014-01-30 00:33:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/149753002/80001
6 years, 10 months ago (2014-01-30 00:34:55 UTC) #4
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=218381
6 years, 10 months ago (2014-01-30 01:05:37 UTC) #5
Jun Mukai
On 2014/01/30 01:05:37, I haz the power (commit-bot) wrote: > Retried try job too often ...
6 years, 10 months ago (2014-01-30 01:59:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/149753002/100001
6 years, 10 months ago (2014-01-30 02:04:51 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-30 03:04:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/149753002/100001
6 years, 10 months ago (2014-01-30 03:14:46 UTC) #9
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=218448
6 years, 10 months ago (2014-01-30 05:10:30 UTC) #10
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 10 months ago (2014-02-03 22:54:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/149753002/100001
6 years, 10 months ago (2014-02-03 22:54:54 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 04:11:01 UTC) #13
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=256077
6 years, 10 months ago (2014-02-04 04:11:02 UTC) #14
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 10 months ago (2014-02-04 04:16:42 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/149753002/100001
6 years, 10 months ago (2014-02-04 04:17:07 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 09:05:52 UTC) #17
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=256337
6 years, 10 months ago (2014-02-04 09:05:52 UTC) #18
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 10 months ago (2014-02-04 09:09:34 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/149753002/100001
6 years, 10 months ago (2014-02-04 09:10:56 UTC) #20
commit-bot: I haz the power
6 years, 10 months ago (2014-02-04 11:08:06 UTC) #21
Message was sent while issue was closed. 
Change committed as 248702

Powered by Google App Engine
This is Rietveld 408576698