Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

Issue 1497523004: move dart completion contributor instantiation (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: merge and address comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart b/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart
index fa4eac95753015457c6bbb91b51d81f2f1b491fe..8f9754ca097b3f5fd9fcea9e00b1614d82031777 100644
--- a/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart
+++ b/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart
@@ -44,18 +44,10 @@ class DartCompletionManager implements CompletionContributor {
*/
Future<List<CompletionSuggestion>> _computeDartSuggestions(
DartCompletionRequest request) async {
- // Build the Dart specific completion contributors
- List<DartCompletionContributor> contributors =
- <DartCompletionContributor>[];
- for (DartCompletionContributorFactory contributorFactory
- in dartCompletionPlugin.contributorFactories) {
- contributors.add(contributorFactory());
- }
-
// Request Dart specific completions from each contributor
List<CompletionSuggestion> suggestions = <CompletionSuggestion>[];
- for (DartCompletionContributor contributor in contributors) {
- suggestions.addAll(await contributor.computeSuggestions(request));
+ for (DartCompletionContributor c in dartCompletionPlugin.contributors) {
+ suggestions.addAll(await c.computeSuggestions(request));
}
return suggestions;
}
« no previous file with comments | « pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698