move dart completion contributor instantiation

move dart completion contributor instantiation

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/e1f6fc7c95c9506d137f950078fb108a3014a206

[danrubel, 2015-12-03 01:41:32]

danrubel@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2015-12-03 01:57:54]

lgtm

https://codereview.chromium.org/1497523004/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart
(right):

https://codereview.chromium.org/1497523004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart:45:
.map((DartCompletionContributorFactory factory) => factory());
Should we convert the result t List?
.toList();

I'm also a little bit worried that we call external code without usual
try/catch/log sequence.
But it might be fine for these presumably simple factories.

[danrubel, 2015-12-03 12:45:25]

https://codereview.chromium.org/1497523004/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart
(right):

https://codereview.chromium.org/1497523004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart:45:
.map((DartCompletionContributorFactory factory) => factory());
On 2015/12/03 01:57:53, scheglov wrote:
> Should we convert the result t List?
> .toList();

Good question. I think for now I will switch the return type to Iterable, which
is all that callers should need.

> I'm also a little bit worried that we call external code without usual
> try/catch/log sequence.
> But it might be fine for these presumably simple factories.

Good point. We may add exception handling here and other places where we hand
off to unknown contributors, but for now CompletionDomainHander #
handleRequest(...) will capture the exception and report it to the client.

[danrubel, 2015-12-03 12:46:03]

Description was changed from

==========
move dart completion contributor instantiation
==========

to

==========
move dart completion contributor instantiation

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e1f6fc7c95c9506d137f950078fb108a3014a206
==========

[danrubel, 2015-12-03 12:46:04]

Committed patchset #2 (id:20001) manually as
e1f6fc7c95c9506d137f950078fb108a3014a206 (presubmit successful).