Tools/DumpRenderTree/chromium/WebViewHost.h - Issue 14975008: test-shell is outside of the screen when running layout tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/DumpRenderTree/chromium/WebViewHost.h

Issue 14975008: test-shell is outside of the screen when running layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@menupopup

Patch Set: Updated per tkent's comments Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Tools/DumpRenderTree/chromium/WebViewHost.h

diff --git a/Tools/DumpRenderTree/chromium/WebViewHost.h b/Tools/DumpRenderTree/chromium/WebViewHost.h

index 985468b2ec92dea5ce93e15bdd6d3cc050760762..757ebe2686557eb2e5c2f2dd12c15ecf60fc85b5 100644

--- a/Tools/DumpRenderTree/chromium/WebViewHost.h

+++ b/Tools/DumpRenderTree/chromium/WebViewHost.h

@@ -203,6 +203,7 @@ class WebViewHost : public WebKit::WebViewClient, public WebKit::WebFrameClient,

// Exposed for WebTestProxy.

void scheduleComposite() { }

+ int screenUnavailabeBorder() { return m_screenUnavailableBorder; }

tkent 2013/05/13 22:45:49 I don't think we need to make this a member functi

private:

@@ -265,6 +266,8 @@ private:

bool m_animateScheduled;

bool m_finished;

+ int m_screenUnavailableBorder;

WebKit::WebRect m_windowRect;

// Edit command associated to the current keyboard event.

« no previous file with comments | « Tools/DumpRenderTree/chromium/TestShell.cpp ('k') | Tools/DumpRenderTree/chromium/WebViewHost.cpp » ('j') | no next file with comments »