[proxies] Make Array.isArray respect proxies.

[proxies] Make Array.isArray respect proxies.

An array is either a JSArray or a proxy whose target is an array.

R=bmeurer@chromium.org
BUG=

Committed: https://crrev.com/82d974799bbdbe549d4641093eee9122503c0b93
Cr-Commit-Position: refs/heads/master@{#32558}

[Benedikt Meurer, 2015-12-03 10:38:53]

https://codereview.chromium.org/1497483004/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/1497483004/diff/1/src/objects-inl.h#newcode182
src/objects-inl.h:182: Maybe<bool> Object::IsArray() const {
Mhm, given that this can throw, we probably should handlify this guy. I.e. turn
it into static Maybe<bool> Object::IsArray(Handle<Object> arg).

[jochen (gone - plz use gerrit), 2015-12-03 10:40:52]

jochen@chromium.org changed reviewers:
+ jochen@chromium.org

[jochen (gone - plz use gerrit), 2015-12-03 10:40:53]

https://codereview.chromium.org/1497483004/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/1497483004/diff/1/src/objects-inl.h#newcode182
src/objects-inl.h:182: Maybe<bool> Object::IsArray() const {
On 2015/12/03 at 10:38:53, Benedikt Meurer wrote:
> Mhm, given that this can throw, we probably should handlify this guy. I.e.
turn it into static Maybe<bool> Object::IsArray(Handle<Object> arg).

there needs to be a way to figure out whether something is an array without
throwing exceptions :-/

[Benedikt Meurer, 2015-12-03 10:41:22]

On 2015/12/03 10:40:53, jochen wrote:
> https://codereview.chromium.org/1497483004/diff/1/src/objects-inl.h
> File src/objects-inl.h (right):
> 
> https://codereview.chromium.org/1497483004/diff/1/src/objects-inl.h#newcode182
> src/objects-inl.h:182: Maybe<bool> Object::IsArray() const {
> On 2015/12/03 at 10:38:53, Benedikt Meurer wrote:
> > Mhm, given that this can throw, we probably should handlify this guy. I.e.
> turn it into static Maybe<bool> Object::IsArray(Handle<Object> arg).
> 
> there needs to be a way to figure out whether something is an array without
> throwing exceptions :-/

Check the spec, this is how Array.isArray is defined.

[neis, 2015-12-03 11:12:19]

On 2015/12/03 10:38:53, Benedikt Meurer wrote:
> https://codereview.chromium.org/1497483004/diff/1/src/objects-inl.h
> File src/objects-inl.h (right):
> 
> https://codereview.chromium.org/1497483004/diff/1/src/objects-inl.h#newcode182
> src/objects-inl.h:182: Maybe<bool> Object::IsArray() const {
> Mhm, given that this can throw, we probably should handlify this guy. I.e.
turn
> it into static Maybe<bool> Object::IsArray(Handle<Object> arg).

Done, new patch uploaded.

[Benedikt Meurer, 2015-12-03 11:53:27]

LGTM.

[neis, 2015-12-03 12:01:45]

The CQ bit was checked by neis@chromium.org

[commit-bot: I haz the power, 2015-12-03 12:01:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1497483004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1497483004/20001

[commit-bot: I haz the power, 2015-12-03 12:51:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-03 12:51:51]

Description was changed from

==========
[proxies] Make Array.isArray respect proxies.

An array is either a JSArray or a proxy whose target is an array.

R=bmeurer@chromium.org
BUG=
==========

to

==========
[proxies] Make Array.isArray respect proxies.

An array is either a JSArray or a proxy whose target is an array.

R=bmeurer@chromium.org
BUG=

Committed: https://crrev.com/82d974799bbdbe549d4641093eee9122503c0b93
Cr-Commit-Position: refs/heads/master@{#32558}
==========

[commit-bot: I haz the power, 2015-12-03 12:51:52]

Patchset 2 (id:??) landed as
https://crrev.com/82d974799bbdbe549d4641093eee9122503c0b93
Cr-Commit-Position: refs/heads/master@{#32558}