Update delegate held by UI utils

Update delegate held by UI utils

In document mode, there are multiple activities and therefore multiple
Reader Mode managers. The UI utils that allow the in-page
javascript to work needs the active manager. This change updates
the reference in UI utils whenever a different tab is shown.

BUG=562360
Committed: https://crrev.com/a102ef96335a4f70d23040c530fee09aac3e126a
Cr-Commit-Position: refs/heads/master@{#363001}

[mdjones, 2015-12-03 00:50:32]

mdjones@chromium.org changed reviewers:
+ dtrainor@google.com, wychen@chromium.org

[mdjones, 2015-12-03 00:50:33]

PTAL

[mdjones, 2015-12-03 00:55:54]

mdjones@chromium.org changed reviewers:
+ dtrainor@chromium.org
- dtrainor@google.com

[wychen, 2015-12-03 00:58:27]

In the description, using "document mode (Hera)", or "document mode" might be
better than "hera".

https://codereview.chromium.org/1497483003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerUIUtils.java
(left):

https://codereview.chromium.org/1497483003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerUIUtils.java:109:
sFeedbackReporter = null;
This deletion seems unrelated.

[mdjones, 2015-12-03 01:01:26]

Description was changed from

==========
Update delegate held by UI utils

In hera, there are multiple activities and therefore multiple
Reader Mode managers. The UI utils that allow the in-page
javascript to work needs the active manager. This change updates
the reference in UI utils whenever a different tab is shown.

BUG=562360
==========

to

==========
Update delegate held by UI utils

In document mode, there are multiple activities and therefore multiple
Reader Mode managers. The UI utils that allow the in-page
javascript to work needs the active manager. This change updates
the reference in UI utils whenever a different tab is shown.

BUG=562360
==========

[mdjones, 2015-12-03 01:04:40]

https://codereview.chromium.org/1497483003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerUIUtils.java
(left):

https://codereview.chromium.org/1497483003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerUIUtils.java:109:
sFeedbackReporter = null;
On 2015/12/03 00:58:27, wychen wrote:
> This deletion seems unrelated.

It's only a little bit related, but I did notice it while making this change.
This reference will be incorrectly cleared each time a tab is closed in document
mode, forcing it to be recreated unnecessarily. I can move this to a separate CL
if you prefer.

[mdjones, 2015-12-03 01:05:02]

On 2015/12/03 01:04:40, mdjones wrote:
>
https://codereview.chromium.org/1497483003/diff/1/chrome/android/java/src/org...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerUIUtils.java
> (left):
> 
>
https://codereview.chromium.org/1497483003/diff/1/chrome/android/java/src/org...
>
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerUIUtils.java:109:
> sFeedbackReporter = null;
> On 2015/12/03 00:58:27, wychen wrote:
> > This deletion seems unrelated.
> 
> It's only a little bit related, but I did notice it while making this change.
> This reference will be incorrectly cleared each time a tab is closed in
document
> mode, forcing it to be recreated unnecessarily. I can move this to a separate
CL
> if you prefer.

Description has also been updated.

[wychen, 2015-12-03 01:18:06]

lgtm

https://codereview.chromium.org/1497483003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerUIUtils.java
(left):

https://codereview.chromium.org/1497483003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerUIUtils.java:109:
sFeedbackReporter = null;
On 2015/12/03 01:04:40, mdjones wrote:
> On 2015/12/03 00:58:27, wychen wrote:
> > This deletion seems unrelated.
> 
> It's only a little bit related, but I did notice it while making this change.
> This reference will be incorrectly cleared each time a tab is closed in
document
> mode, forcing it to be recreated unnecessarily. I can move this to a separate
CL
> if you prefer.

I see. Then just keep it as is.

[David Trainor- moved to gerrit, 2015-12-03 03:20:42]

lgtm

[mdjones, 2015-12-03 16:37:38]

The CQ bit was checked by mdjones@chromium.org

[commit-bot: I haz the power, 2015-12-03 16:38:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1497483003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1497483003/1

[commit-bot: I haz the power, 2015-12-03 17:21:21]

Description was changed from

==========
Update delegate held by UI utils

In document mode, there are multiple activities and therefore multiple
Reader Mode managers. The UI utils that allow the in-page
javascript to work needs the active manager. This change updates
the reference in UI utils whenever a different tab is shown.

BUG=562360
==========

to

==========
Update delegate held by UI utils

In document mode, there are multiple activities and therefore multiple
Reader Mode managers. The UI utils that allow the in-page
javascript to work needs the active manager. This change updates
the reference in UI utils whenever a different tab is shown.

BUG=562360
==========

[commit-bot: I haz the power, 2015-12-03 17:21:22]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-03 17:22:18]

Description was changed from

==========
Update delegate held by UI utils

In document mode, there are multiple activities and therefore multiple
Reader Mode managers. The UI utils that allow the in-page
javascript to work needs the active manager. This change updates
the reference in UI utils whenever a different tab is shown.

BUG=562360
==========

to

==========
Update delegate held by UI utils

In document mode, there are multiple activities and therefore multiple
Reader Mode managers. The UI utils that allow the in-page
javascript to work needs the active manager. This change updates
the reference in UI utils whenever a different tab is shown.

BUG=562360

Committed: https://crrev.com/a102ef96335a4f70d23040c530fee09aac3e126a
Cr-Commit-Position: refs/heads/master@{#363001}
==========

[commit-bot: I haz the power, 2015-12-03 17:22:19]

Patchset 1 (id:??) landed as
https://crrev.com/a102ef96335a4f70d23040c530fee09aac3e126a
Cr-Commit-Position: refs/heads/master@{#363001}