Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1497433003: Modify an enum name (Closed)

Created:
5 years ago by lpromero
Modified:
5 years ago
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Modify an enum name This CL modifies a name to mention only "bookmarks". BUG=378104 R=noyau@chromium.org Committed: https://crrev.com/cd36a7c2cdca2807817e4b8bbe9092e9f693b5bf Cr-Commit-Position: refs/heads/master@{#362947}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ios/chrome/browser/signin/constants.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
lpromero
5 years ago (2015-12-02 20:51:16 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1497433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1497433003/1
5 years ago (2015-12-02 20:52:17 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-02 21:05:10 UTC) #5
noyau (Ping after 24h)
lgtm To pkl for owner.
5 years ago (2015-12-02 22:50:05 UTC) #7
lpromero
sdefresne@chromium.org: Please review changes.
5 years ago (2015-12-03 08:51:44 UTC) #9
sdefresne
lgtm
5 years ago (2015-12-03 09:05:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1497433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1497433003/1
5 years ago (2015-12-03 10:42:45 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 10:51:59 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-03 10:52:31 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd36a7c2cdca2807817e4b8bbe9092e9f693b5bf
Cr-Commit-Position: refs/heads/master@{#362947}

Powered by Google App Engine
This is Rietveld 408576698