Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: pkg/analyzer/lib/src/services/formatter_impl.dart

Issue 149743002: Fix to allow single method cascades to fit on one line (dartbug.com/16384). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/services/data/stmt_tests.data » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/services/formatter_impl.dart
===================================================================
--- pkg/analyzer/lib/src/services/formatter_impl.dart (revision 32133)
+++ pkg/analyzer/lib/src/services/formatter_impl.dart (working copy)
@@ -476,7 +476,10 @@
visitCascadeExpression(CascadeExpression node) {
visit(node.target);
indent(2);
- newlines();
+ // Single cascades do not force a linebreak (dartbug.com/16384)
+ if (node.cascadeSections.length > 1) {
+ newlines();
+ }
visitNodes(node.cascadeSections, separatedBy: newlines);
unindent(2);
}
« no previous file with comments | « no previous file | pkg/analyzer/test/services/data/stmt_tests.data » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698