third_party/WebKit/Source/core/layout/LayoutGrid.cpp - Issue 1497403002: [css-align] Overflow alignment value 'true' renamed to 'unsafe'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutGrid.cpp

Issue 1497403002: [css-align] Overflow alignment value 'true' renamed to 'unsafe' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/CSSValueKeywords.in ('K') | « third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp ('k') | third_party/WebKit/Source/core/style/ComputedStyleConstants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutGrid.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutGrid.cpp b/third_party/WebKit/Source/core/layout/LayoutGrid.cpp

index 1f24ae7d2b8ef22e858796c8160305acfc8d1294..67bbbcf89af2f1b1dbd8c60978b20b94a7fff7f9 100644

--- a/third_party/WebKit/Source/core/layout/LayoutGrid.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutGrid.cpp

@@ -1594,7 +1594,7 @@ static LayoutUnit computeOverflowAlignmentOffset(OverflowAlignment overflow, Lay

// If overflow is 'safe', we have to make sure we don't overflow the 'start'

// edge (potentially cause some data loss as the overflow is unreachable).

return std::max<LayoutUnit>(0, offset);

- case OverflowAlignmentTrue:

+ case OverflowAlignmentUnsafe:

case OverflowAlignmentDefault:

// If we overflow our alignment container and overflow is 'true' (default), we

// ignore the overflow and just return the value regardless (which may cause data