Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1497403002: [css-align] Overflow alignment value 'true' renamed to 'unsafe' (Closed)

Created:
5 years ago by jfernandez
Modified:
5 years ago
CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, blink-reviews-style_chromium.org, zoltan1, svillar, blink-reviews-css, pdr+renderingwatchlist_chromium.org, Manuel Rego, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, blink-reviews, eae+blinkwatch, blink-reviews-layout_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-align] Overflow alignment value 'true' renamed to 'unsafe' The CSS Box Alignment spec changed the syntax of overflow alignment so that the value 'true' has been renamed to 'unsafe'. There is no change in the behavior of the old keyword, just a syntax change, which affects just parsing and computed style logic. diff: https://hg.csswg.org/drafts/rev/f34a2a8b8177 BUG=565883 Committed: https://crrev.com/ead445bd13a3bbb35e1518856fbd23665b6a0716 Cr-Commit-Position: refs/heads/master@{#364691}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Applied suggested changes. #

Patch Set 3 : Fixed repaint tests issues. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+347 lines, -343 lines) Patch
M third_party/WebKit/LayoutTests/fast/alignment/overwrite-content-alignment.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/overwrite-content-alignment-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/overwrite-self-alignment.html View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/overwrite-self-alignment-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/parse-align-content.html View 12 chunks +48 lines, -48 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/parse-align-content-expected.txt View 3 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/parse-align-items.html View 8 chunks +34 lines, -34 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/parse-align-items-expected.txt View 4 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/parse-align-self.html View 9 chunks +34 lines, -34 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/parse-align-self-expected.txt View 4 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/parse-justify-content.html View 11 chunks +46 lines, -46 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/parse-justify-content-expected.txt View 3 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/parse-justify-items.html View 8 chunks +33 lines, -33 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/parse-justify-items-expected.txt View 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/parse-justify-self.html View 9 chunks +34 lines, -34 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/alignment/parse-justify-self-expected.txt View 4 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-align-justify-overflow.html View 11 chunks +18 lines, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-content-alignment-overflow.html View 4 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/align-items-overflow-change.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/align-self-overflow-change.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/justify-items-overflow-change.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/justify-self-overflow-change.html View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSValueKeywords.in View 1 3 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (13 generated)
jfernandez
5 years ago (2015-12-04 23:02:29 UTC) #3
cbiesinger
lgtm for layout
5 years ago (2015-12-04 23:04:51 UTC) #4
Timothy Loh
lgtm https://codereview.chromium.org/1497403002/diff/1/third_party/WebKit/Source/core/css/CSSValueKeywords.in File third_party/WebKit/Source/core/css/CSSValueKeywords.in (right): https://codereview.chromium.org/1497403002/diff/1/third_party/WebKit/Source/core/css/CSSValueKeywords.in#newcode490 third_party/WebKit/Source/core/css/CSSValueKeywords.in:490: unsafe Probably shouldn't list values multiple times in ...
5 years ago (2015-12-07 05:56:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1497403002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1497403002/20001
5 years ago (2015-12-08 11:16:26 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/152192)
5 years ago (2015-12-08 11:45:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1497403002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1497403002/20001
5 years ago (2015-12-09 09:43:38 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/146863)
5 years ago (2015-12-09 11:06:11 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1497403002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1497403002/40001
5 years ago (2015-12-11 10:24:58 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/79362)
5 years ago (2015-12-11 10:47:01 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1497403002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1497403002/40001
5 years ago (2015-12-11 12:46:52 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-11 13:46:12 UTC) #23
commit-bot: I haz the power
5 years ago (2015-12-11 13:47:06 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ead445bd13a3bbb35e1518856fbd23665b6a0716
Cr-Commit-Position: refs/heads/master@{#364691}

Powered by Google App Engine
This is Rietveld 408576698