Blacklist API change for allowing multiple rule matches...

Blacklist API change for allowing multiple rule matches

The findMatch function now returns a Match object which aggregates multiple
entries into one, in case (which is expected to be common) that multiple
rules match a given URL.

Since the set of matches is highly dependent on the URL, the Match class
replaces the old RequestData object to be added to URLRequests.

BUG=16932
TEST=Blacklist*

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20886

[Sverrir, 2009-07-16 19:34:39]

LGTM

Possibly add some more tests for "nasty" url's and matches - since both the
pb-lists and the url's are potentially malicious.

http://codereview.chromium.org/149737/diff/1005/19
File chrome/browser/privacy_blacklist/blacklist.cc (right):

http://codereview.chromium.org/149737/diff/1005/19#newcode57
Line 57: while (pattern[++p] == '@');  // Consecutive @ are redundant.
@ symbol at end of input will cause a boom?

http://codereview.chromium.org/149737/diff/1005/19#newcode70
Line 70: (url.compare(url.size() - pr, pr, pattern.c_str() + p) == 0);
4 space indent

http://codereview.chromium.org/149737/diff/1005/19#newcode126
Line 126: i != entries_.end(); ++i) {
4 space indent

http://codereview.chromium.org/149737/diff/1005/18
File chrome/browser/renderer_host/resource_message_filter.cc (right):

http://codereview.chromium.org/149737/diff/1005/18#newcode442
Line 442: }
add a scope for the first if.