Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: chrome/browser/extensions/extension_service.h

Issue 14973007: Auto-install/uninstall shared module dependencies for extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update checkimports logic per feedback Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service.h
diff --git a/chrome/browser/extensions/extension_service.h b/chrome/browser/extensions/extension_service.h
index d6754a14183b4254d35823293a0741573d3d7d21..d9a80fa077ca06c7747a8d63b1ca7dcef18a080f 100644
--- a/chrome/browser/extensions/extension_service.h
+++ b/chrome/browser/extensions/extension_service.h
@@ -66,7 +66,7 @@ class ExtensionSystem;
class ExtensionUpdater;
class PendingExtensionManager;
class SettingsFrontend;
-}
+} // namespace extensions
Matt Perry 2013/06/12 00:58:29 nit: 2 spaces before //. But the comment is unnece
elijahtaylor1 2013/06/12 23:53:23 I did this in response to a presubmit check. It o
namespace syncer {
class SyncErrorFactory;
@@ -410,6 +410,20 @@ class ExtensionService
virtual void AddComponentExtension(const extensions::Extension* extension)
OVERRIDE;
+ // Checks an extension's shared module imports to see if they are satisfied.
+ // If they are not, this function adds the dependencies to the pending install
+ // list if |extension| came from the webstore.
+ bool CheckImports(const extensions::Extension* extension);
+
+ // Returns a set of extensions that import a given extension.
+ scoped_ptr<const ExtensionSet> GetSharedModuleImporters(
+ const extensions::Extension* extension);
+
+ // Checks an extension's shared module imports to see if they would still be
+ // referenced by other extensions when a particular extension is uninstalled.
+ // Uninstalls shared modules that are no longer referenced.
+ void PruneSharedModulesOnUninstall(const extensions::Extension* extension);
+
// Informs the service that an extension's files are in place for loading.
//
// Please make sure the Blacklist is checked some time before calling this
@@ -420,6 +434,9 @@ class ExtensionService
bool has_requirement_errors,
bool wait_for_idle);
+ // Checks for delayed installation for all pending installs.
+ void MaybeFinishDelayedInstallations();
+
// Similar to FinishInstallation, but first checks if there still is an update
// pending for the extension, and makes sure the extension is still idle.
void MaybeFinishDelayedInstallation(const std::string& extension_id);
@@ -801,13 +818,8 @@ class ExtensionService
// they can easily be un-blacklisted.
ExtensionSet blacklisted_extensions_;
- // The list of extension updates that have had their installs delayed because
- // they are waiting for idle.
- ExtensionSet delayed_updates_for_idle_;
-
- // The list of extension installs delayed by |installs_delayed_|.
- // This is a disjoint set from |delayed_updates_for_idle_|. Extensions in
- // the |delayed_installs_| do not need to wait for idle.
+ // The list of extension installs delayed for various reasons. The reason
+ // for delayed install is stored in ExtensionPrefs.
ExtensionSet delayed_installs_;
// Hold the set of pending extensions.

Powered by Google App Engine
This is Rietveld 408576698