Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 14973002: Unskip a bunch of skipped tests in order to figure out what to do with them next based off what the… (Closed)

Created:
7 years, 7 months ago by ojan
Modified:
7 years, 7 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Unskip a bunch of skipped tests in order to figure out what to do with them next based off what they actually do on the bots. Most will likely just be rebaselined. I avoided touching any of the ones that are skipped due to affecting the running of other tests or due to missing features in DRT. Gave them all [ Failure ImageOnlyFailure Pass Crash Timeout ] expectations in the hopes of avoiding turning the tree red. BUG=237679 R=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149700

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -120 lines) Patch
M LayoutTests/TestExpectations View 31 chunks +119 lines, -120 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ojan
7 years, 7 months ago (2013-05-05 03:34:27 UTC) #1
eseidel
lgtm Hopefully these don't bleed into other tests. rs=me.
7 years, 7 months ago (2013-05-05 03:48:05 UTC) #2
ojan
Committed patchset #1 manually as r149700 (presubmit successful).
7 years, 7 months ago (2013-05-05 18:30:14 UTC) #3
ojan
7 years, 7 months ago (2013-05-06 05:58:33 UTC) #4
Message was sent while issue was closed.
FWIW, I've been watching the tree pretty closely since this landed and haven't
seen any new instability.

Powered by Google App Engine
This is Rietveld 408576698