Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1497233002: [deoptimizer] Also print the actual literal when printing translations. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[deoptimizer] Also print the actual literal when printing translations. R=jarin@chromium.org Committed: https://crrev.com/552437c08e8cfba90a9b42be23bf37829a8af4be Cr-Commit-Position: refs/heads/master@{#32632}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/objects.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years ago (2015-12-04 17:27:45 UTC) #1
Benedikt Meurer
Hey Jaro, Useful fix for the printer. Please take a look. THanks, Benedikt
5 years ago (2015-12-04 17:28:30 UTC) #2
Jarin
lgtm
5 years ago (2015-12-06 14:38:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1497233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1497233002/1
5 years ago (2015-12-06 15:01:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-06 15:44:48 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-06 15:45:11 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/552437c08e8cfba90a9b42be23bf37829a8af4be
Cr-Commit-Position: refs/heads/master@{#32632}

Powered by Google App Engine
This is Rietveld 408576698