Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 149723005: Patch re2 to support MSan. (Closed)

Created:
6 years, 10 months ago by earthdok
Modified:
6 years, 10 months ago
Reviewers:
Nico, eugenis
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : address eugenis's suggestions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -4 lines) Patch
M third_party/re2/README.chromium View 1 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/re2/patches/re2-msan.patch View 1 1 chunk +63 lines, -0 lines 0 comments Download
M third_party/re2/util/sparse_array.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/re2/util/sparse_set.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/re2/util/util.h View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
earthdok
PTAL. Never patched third_party before - did I do it right?
6 years, 10 months ago (2014-01-29 23:00:56 UTC) #1
eugenis
https://codereview.chromium.org/149723005/diff/1/third_party/re2/util/sparse_array.h File third_party/re2/util/sparse_array.h (right): https://codereview.chromium.org/149723005/diff/1/third_party/re2/util/sparse_array.h#newcode235 third_party/re2/util/sparse_array.h:235: #if defined(MEMORY_SANITIZER) I think it would be cleaner to ...
6 years, 10 months ago (2014-01-30 09:02:55 UTC) #2
eugenis
And please mention the upstream change and why we need to handle it differently in ...
6 years, 10 months ago (2014-01-30 09:03:41 UTC) #3
earthdok
done
6 years, 10 months ago (2014-01-30 12:51:30 UTC) #4
eugenis
Patch at the below link adds one more location where memory must be initialized. Could ...
6 years, 10 months ago (2014-01-30 13:11:11 UTC) #5
earthdok
On 2014/01/30 13:11:11, eugenis wrote: > Patch at the below link adds one more location ...
6 years, 10 months ago (2014-01-30 13:26:09 UTC) #6
eugenis
On 2014/01/30 13:26:09, earthdok wrote: > On 2014/01/30 13:11:11, eugenis wrote: > > Patch at ...
6 years, 10 months ago (2014-01-30 13:27:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/149723005/20001
6 years, 10 months ago (2014-01-30 13:33:57 UTC) #8
commit-bot: I haz the power
Change committed as 247998
6 years, 10 months ago (2014-01-30 18:11:23 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-30 18:11:28 UTC) #10
Nico
Thank you for checking that there is an upstream bug and for mentioning it in ...
6 years, 10 months ago (2014-02-06 17:26:02 UTC) #11
eugenis
6 years, 10 months ago (2014-02-07 10:55:13 UTC) #12
https://code.google.com/p/re2/issues/detail?id=106

On Thu, Feb 6, 2014 at 9:26 PM,  <thakis@chromium.org> wrote:
> Thank you for checking that there is an upstream bug and for mentioning it
> in
> the README change!
>
> It might be worth to file a new issue for
> https://code.google.com/p/re2/issues/detail?id=77#c2 given that that's just
> a
> comment on a bug that's marked Fixed at the moment.
>
> https://codereview.chromium.org/149723005/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698