Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1497213002: Fix test by removing the --noopt flag from the test file. (Closed)

Created:
5 years ago by Florian Schneider
Modified:
5 years ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix test by removing the --noopt flag from the test file. Not all platforms (ia32) support --noopt, and test.py --noopt will run the test with this option anyway. TBR=rmacnak@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/2b7ff6dfaba9723ee1fa467554b8c2fd4b42ae29

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/language/vm/precompiled_static_initializer_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Florian Schneider
tbr
5 years ago (2015-12-04 12:08:01 UTC) #3
Florian Schneider
Committed patchset #1 (id:1) manually as 2b7ff6dfaba9723ee1fa467554b8c2fd4b42ae29 (presubmit successful).
5 years ago (2015-12-04 12:08:19 UTC) #5
rmacnak
5 years ago (2015-12-04 17:36:02 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698