Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 14972010: Switch depot_tools python to 2.7.4. (Closed)

Created:
7 years, 7 months ago by M-A Ruel
Modified:
7 years, 7 months ago
Reviewers:
iannucci, Jói
CC:
chromium-reviews, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, csharp, Sigurður Ásgeirsson
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M .gitignore View 1 chunk +2 lines, -0 lines 0 comments Download
M PRESUBMIT.py View 1 chunk +1 line, -0 lines 0 comments Download
M bootstrap/win/pylint.new.bat View 1 chunk +1 line, -2 lines 0 comments Download
M bootstrap/win/python.new.bat View 1 chunk +6 lines, -2 lines 0 comments Download
M bootstrap/win/win_tools.bat View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
M-A Ruel
+Joi Sadly, this makes the "pops up a header file on gclient runhooks" happen on ...
7 years, 7 months ago (2013-05-08 17:08:21 UTC) #1
Jói
D'oh! So I guess this change is blocked on fixing that problem? I have an ...
7 years, 7 months ago (2013-05-08 17:58:48 UTC) #2
M-A Ruel
On 2013/05/08 17:58:48, Jói wrote: > D'oh! > > So I guess this change is ...
7 years, 7 months ago (2013-05-08 18:12:46 UTC) #3
Dirk Pranke
On 2013/05/08 18:12:46, Marc-Antoine Ruel wrote: > On 2013/05/08 17:58:48, Jói wrote: > > D'oh! ...
7 years, 7 months ago (2013-05-08 18:51:12 UTC) #4
M-A Ruel
On 2013/05/08 18:51:12, Dirk Pranke wrote: > Any particular reason we're upgrading to 2.7 on ...
7 years, 7 months ago (2013-05-08 18:54:43 UTC) #5
Jói
> It'd be appreciated if you could because the roll out is blocked on that ...
7 years, 7 months ago (2013-05-08 22:29:33 UTC) #6
M-A Ruel
I tested manually on http://build.chromium.org/p/chromium.swarm/builders/Windows%20Isolate%20Tests/builds/2385 and no problem came up. So this CL is ready ...
7 years, 7 months ago (2013-05-16 15:43:20 UTC) #7
Jói
LGTM
7 years, 7 months ago (2013-05-16 16:56:24 UTC) #8
M-A Ruel
On 2013/05/16 16:56:24, Jói wrote: > LGTM I'll commit this morning as the tree happens ...
7 years, 7 months ago (2013-05-17 12:44:13 UTC) #9
M-A Ruel
Committed patchset #1 manually as r200799.
7 years, 7 months ago (2013-05-17 12:46:20 UTC) #10
M-A Ruel
7 years, 7 months ago (2013-05-17 12:48:40 UTC) #11
Message was sent while issue was closed.
On 2013/05/17 12:46:20, Marc-Antoine Ruel wrote:
> Committed patchset #1 manually as r200799.

Sadly, I had to bypass the presubmit checks because the tests are still broken
on Windows. This should be fixed, first step would be to include svnadmin in
svn_bin/.

Powered by Google App Engine
This is Rietveld 408576698