Issue 1497113003: Add a queued_data_bytes() method to ReliableQuicStream. Not used outside of tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1497113003: Add a queued_data_bytes() method to ReliableQuicStream. Not used outside of tests. (Closed)

Created:
5 years ago by Jo Kulik

Modified:
5 years ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@108727610

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add a queued_data_bytes() method to ReliableQuicStream. Not used outside of tests. This will be used when sending Trailers. To calculate the :final-offset value the stream must sum stream_bytes_written() + queued_data_bytes(). Merge internal change: 108735153 R=rch@chromium.org BUG=

Patch Set 1 #

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -1 line)			Patch
M	net/quic/reliable_quic_stream.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	net/quic/reliable_quic_stream.cc	View	3 chunks	+4 lines, -1 line	0 comments	Download
M	net/quic/reliable_quic_stream_test.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Depends on Patchset:

Issue 1499673003 Patch 1

Dependent Patchsets:

Issue 1495243002 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages