Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 14971004: Add a llvm lit test for NaCl ARM/X86 support for bswap i16, i32, i64. (Closed)

Created:
7 years, 7 months ago by jvoung (off chromium)
Modified:
7 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/pnacl-llvm.git@master
Visibility:
Public.

Description

Add a llvm lit test for NaCl ARM/X86 support for bswap i16, i32, i64. Slowly trying to promote "dev" intrinsics that are being tested to be accepted. Luckily, bswap is supported without compiler_rt for ARM and x86 at least. Test at default level and -O0. Also tested by gcc/testsuite/gcc.dg/builtin-bswap-[1,2,3,4,5].c, and a couple of other gcc tests. We may want to blacklist odd argument sizes like i8, and i1, which the x86 backend won't handle. The i16 case is also interesting, however, it's easy to do if you have an i32 bswap. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3378 R=eliben@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=4fbe1a0

Patch Set 1 #

Patch Set 2 : typo #

Patch Set 3 : add tests for consts #

Total comments: 2

Patch Set 4 : rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -0 lines) Patch
A test/NaCl/ARM/intrinsics-bitmanip.ll View 1 2 3 1 chunk +64 lines, -0 lines 0 comments Download
A test/NaCl/X86/intrinsics-bitmanip.ll View 1 2 3 1 chunk +74 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jvoung (off chromium)
7 years, 7 months ago (2013-05-08 21:09:43 UTC) #1
eliben
lgtm
7 years, 7 months ago (2013-05-08 21:33:03 UTC) #2
Mark Seaborn
https://codereview.chromium.org/14971004/diff/4001/test/NaCl/ARM/intrinsics_bitmanip.ll File test/NaCl/ARM/intrinsics_bitmanip.ll (right): https://codereview.chromium.org/14971004/diff/4001/test/NaCl/ARM/intrinsics_bitmanip.ll#newcode1 test/NaCl/ARM/intrinsics_bitmanip.ll:1: ; RUN: llc -mtriple=armv7-unknown-nacl -filetype=asm %s -o - | ...
7 years, 7 months ago (2013-05-08 21:39:53 UTC) #3
jvoung (off chromium)
https://codereview.chromium.org/14971004/diff/4001/test/NaCl/ARM/intrinsics_bitmanip.ll File test/NaCl/ARM/intrinsics_bitmanip.ll (right): https://codereview.chromium.org/14971004/diff/4001/test/NaCl/ARM/intrinsics_bitmanip.ll#newcode1 test/NaCl/ARM/intrinsics_bitmanip.ll:1: ; RUN: llc -mtriple=armv7-unknown-nacl -filetype=asm %s -o - | ...
7 years, 7 months ago (2013-05-09 17:23:49 UTC) #4
jvoung (off chromium)
7 years, 7 months ago (2013-05-09 17:52:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r4fbe1a0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698