Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 14971002: GTTF: move chrome/browser/google_apis/test_server to net/test (Closed)

Created:
7 years, 7 months ago by Paweł Hajdan Jr.
Modified:
7 years, 7 months ago
Reviewers:
satorux1, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, derat+watch_chromium.org, tfarina, Aaron Boodman, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

GTTF: move chrome/browser/google_apis/test_server to net/test This is a part of replacing most usages of the Python test server with an in-process C++ test server that should be easier to debug. BUG=96594 R=rch@chromium.org, satorux@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198762

Patch Set 1 #

Total comments: 3

Patch Set 2 : rebased, OWNERS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -1310 lines) Patch
M chrome/browser/chromeos/contacts/gdata_contacts_service_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/oobe_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/streams_private/streams_private_apitest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/google_apis/base_operations_server_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/google_apis/drive_api_operations_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_operations_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
D chrome/browser/google_apis/test_server/http_connection.h View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/browser/google_apis/test_server/http_connection.cc View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/browser/google_apis/test_server/http_request.h View 1 chunk +0 lines, -115 lines 0 comments Download
D chrome/browser/google_apis/test_server/http_request.cc View 1 chunk +0 lines, -202 lines 0 comments Download
D chrome/browser/google_apis/test_server/http_request_unittest.cc View 1 chunk +0 lines, -82 lines 0 comments Download
D chrome/browser/google_apis/test_server/http_response.h View 1 chunk +0 lines, -71 lines 0 comments Download
D chrome/browser/google_apis/test_server/http_response.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D chrome/browser/google_apis/test_server/http_response_unittest.cc View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/google_apis/test_server/http_server.h View 1 chunk +0 lines, -161 lines 0 comments Download
D chrome/browser/google_apis/test_server/http_server.cc View 1 chunk +0 lines, -213 lines 0 comments Download
D chrome/browser/google_apis/test_server/http_server_unittest.cc View 1 chunk +0 lines, -223 lines 0 comments Download
M chrome/browser/google_apis/test_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 chunks +0 lines, -11 lines 0 comments Download
M net/net.gyp View 1 2 chunks +11 lines, -0 lines 0 comments Download
A + net/test/embedded_test_server/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/test/embedded_test_server/http_connection.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + net/test/embedded_test_server/http_connection.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + net/test/embedded_test_server/http_request.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + net/test/embedded_test_server/http_request.cc View 1 chunk +1 line, -1 line 0 comments Download
A + net/test/embedded_test_server/http_request_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + net/test/embedded_test_server/http_response.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + net/test/embedded_test_server/http_response.cc View 1 chunk +1 line, -1 line 0 comments Download
A + net/test/embedded_test_server/http_response_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + net/test/embedded_test_server/http_server.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + net/test/embedded_test_server/http_server.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + net/test/embedded_test_server/http_server_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Paweł Hajdan Jr.
7 years, 7 months ago (2013-05-04 21:19:30 UTC) #1
tfarina
I think Satoru-san and mtomaz wrote this http server. Would be fine to have an ...
7 years, 7 months ago (2013-05-04 22:37:38 UTC) #2
Ryan Hamilton
https://codereview.chromium.org/14971002/diff/1/net/test/embedded_test_server/http_connection.h File net/test/embedded_test_server/http_connection.h (right): https://codereview.chromium.org/14971002/diff/1/net/test/embedded_test_server/http_connection.h#newcode18 net/test/embedded_test_server/http_connection.h:18: namespace google_apis { Here and elsewhere, I think this ...
7 years, 7 months ago (2013-05-06 15:33:09 UTC) #3
Paweł Hajdan Jr.
https://codereview.chromium.org/14971002/diff/1/net/test/embedded_test_server/http_connection.h File net/test/embedded_test_server/http_connection.h (right): https://codereview.chromium.org/14971002/diff/1/net/test/embedded_test_server/http_connection.h#newcode18 net/test/embedded_test_server/http_connection.h:18: namespace google_apis { On 2013/05/06 15:33:09, Ryan Hamilton wrote: ...
7 years, 7 months ago (2013-05-06 23:52:46 UTC) #4
satorux1
On 2013/05/06 23:52:46, Paweł Hajdan Jr. wrote: > https://codereview.chromium.org/14971002/diff/1/net/test/embedded_test_server/http_connection.h > File net/test/embedded_test_server/http_connection.h (right): > > ...
7 years, 7 months ago (2013-05-07 01:33:20 UTC) #5
Ryan Hamilton
On 2013/05/06 23:52:46, Paweł Hajdan Jr. wrote: > https://codereview.chromium.org/14971002/diff/1/net/test/embedded_test_server/http_connection.h > File net/test/embedded_test_server/http_connection.h (right): > > ...
7 years, 7 months ago (2013-05-07 03:43:25 UTC) #6
satorux1
LGTM. Can you add net/test/embedded_test_server/OWNERS with me and mtomasz@chromium.org included? Please feel free to do ...
7 years, 7 months ago (2013-05-07 06:00:47 UTC) #7
Ryan Hamilton
On 2013/05/07 03:43:25, Ryan Hamilton wrote: > On 2013/05/06 23:52:46, Paweł Hajdan Jr. wrote: > ...
7 years, 7 months ago (2013-05-07 17:17:04 UTC) #8
Paweł Hajdan Jr.
7 years, 7 months ago (2013-05-07 17:50:36 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 manually as r198762.

Powered by Google App Engine
This is Rietveld 408576698