Issue 149710: Fix 307 redirects of a POST request to actually send the body again, and add ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149710: Fix 307 redirects of a POST request to actually send the body again, and add ... (Closed)

Created:
11 years, 5 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
abarth-chromium

CC:
chromium-reviews_googlegroups.com, darin (slow to review), willchan no longer on Chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix 307 redirects of a POST request to actually send the body again, and add a test. Note: the fix is trivial, but adding support for a test required teaching the FileHandler of testserver to consume a post body. BUG=16832 TEST=covered by unit test R=abarth Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22100

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
A +	net/data/url_request_unittest/redirect307-to-echo.mock-http-headers	View		1 chunk	+1 line, -1 line	0 comments	Download
D	net/data/url_request_unittest/redirect307-to-echoall	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
D	net/data/url_request_unittest/redirect307-to-echoall.mock-http-headers	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
M	net/url_request/url_request.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	net/url_request/url_request_unittest.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
A +	net\data\url_request_unittest\redirect307-to-echo	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages