Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1636)

Unified Diff: pkg/analysis_server/lib/src/status/get_handler.dart

Issue 1497083003: Report targets will null entries in status pages (prevents an NPE) (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/status/get_handler.dart
diff --git a/pkg/analysis_server/lib/src/status/get_handler.dart b/pkg/analysis_server/lib/src/status/get_handler.dart
index 898dda8b150543b09adc7b44dc58ca5597983b8a..c1c1663481b39558d8def7e7dff144a89ee9012b 100644
--- a/pkg/analysis_server/lib/src/status/get_handler.dart
+++ b/pkg/analysis_server/lib/src/status/get_handler.dart
@@ -679,6 +679,7 @@ class GetHandler {
List<Folder> allContexts = <Folder>[];
Map<Folder, List<CacheEntry>> entryMap =
new HashMap<Folder, List<CacheEntry>>();
+ StringBuffer invalidKeysBuffer = new StringBuffer();
analysisServer.folderMap
.forEach((Folder folder, InternalAnalysisContext context) {
Source source = context.sourceFactory.forUri(sourceUri);
@@ -695,7 +696,15 @@ class GetHandler {
entries = <CacheEntry>[];
entryMap[folder] = entries;
}
- entries.add(iterator.value);
+ CacheEntry value = iterator.value;
+ if (value == null) {
+ if (invalidKeysBuffer.isNotEmpty) {
+ invalidKeysBuffer.write(', ');
+ }
+ invalidKeysBuffer.write(iterator.key.toString());
+ } else {
+ entries.add(value);
+ }
}
}
}
@@ -707,6 +716,11 @@ class GetHandler {
_writeResponse(request, (StringBuffer buffer) {
_writePage(buffer, 'Analysis Server - Cache Entry',
['Context: $contextFilter', 'File: $sourceUri'], (HttpResponse) {
+ if (invalidKeysBuffer.isNotEmpty) {
+ buffer.write('<h3>Targets with null Entries</h3><p>');
+ buffer.write(invalidKeysBuffer.toString());
+ buffer.write('</p>');
+ }
List<CacheEntry> entries = entryMap[folder];
buffer.write('<h3>Analyzing Contexts</h3><p>');
bool first = true;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698