Elide proxy authentication headers

Elide proxy authentication headers

The change prevent the data reduction proxy's authentication
headers from being exposed in net logs and dev tools.

BUG=179382
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248566

[bengr, 2014-01-30 18:46:13]

On 2014/01/30 01:29:22, bengr1 wrote:

mef: everything

[mef, 2014-01-30 23:10:28]

On 2014/01/30 18:46:13, bengr1 wrote:
> On 2014/01/30 01:29:22, bengr1 wrote:
> 
> mef: everything

Looks ok, I'm just wondering if there is a way to avoid duplication of code
and/or string constants...

[bengr, 2014-01-31 17:19:08]

On 2014/01/30 23:10:28, mef wrote:
> On 2014/01/30 18:46:13, bengr1 wrote:
> > On 2014/01/30 01:29:22, bengr1 wrote:
> > 
> > mef: everything
> 
> Looks ok, I'm just wondering if there is a way to avoid duplication of code
> and/or string constants...

Not easily. Sometime soon, I'd like to decide if we should elide auth headers
for all platforms. If so, then we could move these functions and string
constants to HttpUtil or some other common location.

[bengr, 2014-02-03 17:17:21]

On 2014/01/31 17:19:08, bengr1 wrote:
> On 2014/01/30 23:10:28, mef wrote:
> > On 2014/01/30 18:46:13, bengr1 wrote:
> > > On 2014/01/30 01:29:22, bengr1 wrote:
> > > 
> > > mef: everything
> > 
> > Looks ok, I'm just wondering if there is a way to avoid duplication of code
> > and/or string constants...
> 
> Not easily. Sometime soon, I'd like to decide if we should elide auth headers
> for all platforms. If so, then we could move these functions and string
> constants to HttpUtil or some other common location.

Would you approve the change?

[mef, 2014-02-03 17:18:25]

On 2014/02/03 17:17:21, bengr1 wrote:
> On 2014/01/31 17:19:08, bengr1 wrote:
> > On 2014/01/30 23:10:28, mef wrote:
> > > On 2014/01/30 18:46:13, bengr1 wrote:
> > > > On 2014/01/30 01:29:22, bengr1 wrote:
> > > > 
> > > > mef: everything
> > > 
> > > Looks ok, I'm just wondering if there is a way to avoid duplication of
code
> > > and/or string constants...
> > 
> > Not easily. Sometime soon, I'd like to decide if we should elide auth
headers
> > for all platforms. If so, then we could move these functions and string
> > constants to HttpUtil or some other common location.
> 
> Would you approve the change?

Yes, sorry. lgtm

[bengr, 2014-02-03 17:35:59]

The CQ bit was checked by bengr@chromium.org

[commit-bot: I haz the power, 2014-02-03 17:36:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bengr@chromium.org/149703005/1

[commit-bot: I haz the power, 2014-02-03 20:31:28]

Change committed as 248566

[commit-bot: I haz the power, 2014-02-03 20:31:28]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-02-03 20:31:43]

CQ bit was unchecked on CL. Ignoring.