Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Issue 149703004: Fix onLocalDescriptionError callback in WebRtcBrowserTest (Closed)

Created:
6 years, 10 months ago by sheu
Modified:
6 years, 10 months ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Fix onLocalDescriptionError callback in WebRtcBrowserTest Make sure the onLocalDescriptionError callback is set before it can possibly be called as a side-effect of webkitGetUserMedia(). BUG=339286 TEST=local build, run on desktop Linux Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247953

Patch Set 1 : 6fd1b301 Initial. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M content/test/data/media/peerconnection-call.html View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sheu
phoglund: PTAL.
6 years, 10 months ago (2014-01-30 00:32:37 UTC) #1
phoglund_chromium
If you think this makes anything better: lgtm
6 years, 10 months ago (2014-01-30 09:10:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheu@chromium.org/149703004/20001
6 years, 10 months ago (2014-01-30 09:14:35 UTC) #3
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 13:53:49 UTC) #4
Message was sent while issue was closed.
Change committed as 247953

Powered by Google App Engine
This is Rietveld 408576698