Issue 149703004: Fix onLocalDescriptionError callback in WebRtcBrowserTest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149703004: Fix onLocalDescriptionError callback in WebRtcBrowserTest (Closed)

Created:
6 years, 10 months ago by sheu

Modified:
6 years, 10 months ago

Reviewers:
phoglund_chromium

CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix onLocalDescriptionError callback in WebRtcBrowserTest Make sure the onLocalDescriptionError callback is set before it can possibly be called as a side-effect of webkitGetUserMedia(). BUG=339286 TEST=local build, run on desktop Linux Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247953

Patch Set 1 : 6fd1b301 Initial. #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	content/test/data/media/peerconnection-call.html	View		3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheu@chromium.org/149703004/20001

6 years, 10 months ago (2014-01-30 09:14:35 UTC) #3

Message was sent while issue was closed.

Change committed as 247953

Expand Messages | Collapse Messages