Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 149703003: Mojo: Remove '*' from the list of unary operators in mojom expressions. (Closed)

Created:
6 years, 10 months ago by viettrungluu
Modified:
6 years, 10 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Remove '*' from the list of unary operators in mojom expressions. R=mpcomplete@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247880

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M mojo/public/bindings/pylib/parse/mojo_parser.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
I can't think of a valid use for unary * in mojom constant expressions, can ...
6 years, 10 months ago (2014-01-29 22:27:29 UTC) #1
Matt Perry
Nope, LGTM
6 years, 10 months ago (2014-01-29 23:51:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/149703003/1
6 years, 10 months ago (2014-01-30 01:18:19 UTC) #3
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 07:44:36 UTC) #4
Message was sent while issue was closed.
Change committed as 247880

Powered by Google App Engine
This is Rietveld 408576698